feat: native-stack + shared transitions#3759
feat: native-stack + shared transitions#3759ajaysehwal wants to merge 3 commits intoZeusLN:masterfrom
Conversation
Summary of ChangesHello @ajaysehwal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the application's navigation by migrating to Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully implements native stack navigation and shared element transitions for contact details, which significantly enhances the user experience. The changes are well-implemented using react-native-reanimated. I've identified a couple of areas for improvement: an inconsistent animation duration between screens which could affect the transition's smoothness, and some code duplication in the ContactDetails view that could be refactored for better maintainability. Overall, this is a great feature addition.
000621e to
2610aca
Compare
2610aca to
bcf6582
Compare
Description
Please enter a description and screenshots, if appropriate, of the work covered in this PR
In This PR migrates our navigation setup from @react-navigation/native to @react-navigation/native-stack to enable support for shared transition animations and improved native animations across the app. By using the native stack navigator, we can leverage smoother transitions and better performance compared to the JS-based stack.
Reference
Native Stack Navigator Docs:
https://reactnavigation.org/docs/native-stack-navigator
Shared Transitions Docs:
https://reactnavigation.org/docs/shared-element-transitions/
Screen.Recording.2026-03-02.at.5.56.49.PM.mov
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: