ui: dedicated success screens for channel open & peer connect#3748
ui: dedicated success screens for channel open & peer connect#3748myxmaster wants to merge 4 commits intoZeusLN:masterfrom
Conversation
Summary of ChangesHello @myxmaster, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience for critical operations like opening Lightning channels and connecting to peers. By implementing dedicated success screens, the application now provides clearer, more contextual feedback to the user, along with direct pathways to relevant next steps. This change moves away from generic notifications towards a more guided and informative post-action flow. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces dedicated success screens for channel opening and peer connection, providing a cleaner and more informative user experience. I have identified a critical issue regarding tab navigation in localized environments and suggested a fix to ensure consistent behavior across all languages.
f37ad55 to
6b2ecf4
Compare
|
@myxmaster can you please rebase this PR ? so we can have latest rn84 changes here |
6b2ecf4 to
8c73744
Compare
shubhamkmr04
left a comment
There was a problem hiding this comment.
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-02.at.20.55.14.mov
for the backends that don't have option for pending channels view
|
good catch. so we just hide the "VIEW STATUS" button in that case, right? |
right. that works |
8c73744 to
1ed385b
Compare
|
Regarding the last commit: While investigating the peer connect flow, I noticed that the CLNRest backend always includes |
shubhamkmr04
left a comment
There was a problem hiding this comment.
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-04.at.22.45.12.mov
we are not getting redirected to pending channel tab
|
Ok that was an existing bug. Root cause: Fix: Additionally fixed the flashing empty |
Description
This fixes #2166 by displaying dedicated success screens similar to successful payments.
I do find the big ZEUS logo, animated check mark and lightning bolts a bit too celebratory for this, so I made a calm success message, short summary and useful action buttons.
Error case is unchanged -> an inline error message via SuccessErrorMessage component makes sense here.
For open channel:
Button "VIEW STATUS" navigates to channels pane > pending channels tab.
For peer connect:
Button "OPEN CHANNEL TO THIS PEER" navigates to open channel screen and pre-fills inputs with pubkey/host of the just connected peer.
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: