-
-
Notifications
You must be signed in to change notification settings - Fork 77
fix: use electron.net for beatmods.com requests to avoid Cloudflare timeouts #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae8086a to
0832357
Compare
0832357 to
faeaa7d
Compare
… of file write operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
Zagrios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙌
|
Thanks a lot @moreveal ❤️ |



Scope
Requests to
https://beatmods.com/api/modsmay hang or timeout when executedfrom the Electron main process, while the same endpoints work reliably
in browsers.
This results in an infinite "Loading mods" state for users.
Implementation
Requests to
beatmods.comare routed through Electron's Chromium network stackusing
electron.net.This avoids Cloudflare-related issues observed with Node.js HTTP clients on
large responses. The change is scoped only to
beatmods.com; all other requestsremain unchanged.
How to Test
npm run start).Emoji Guide
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
E.g: Blocking feedback must be addressed before merging.
Note
Resolves Cloudflare timeouts by routing BeatMods traffic through Electron’s Chromium network stack.
isBeatmodsUrland conditionally uses newelectron.netimplementations forgetJSON,downloadFile, anddownloadBufferrequestWithElectronNet,downloadFileWithElectronNet, anddownloadBufferWithElectronNetwith HTTP status validation, timeout/error handling, progress updates, andcontent-dispositionfilename supportgot-based logic (including IPv4/IPv6 family preference caching) for non-BeatMods URLs; headers unchanged viabaseHeadersWritten by Cursor Bugbot for commit 27c241e. This will update automatically on new commits. Configure here.