Skip to content

Conversation

@ImSapphire
Copy link
Contributor

Scope

Inherits environment when starting wine for BSIPA installation, which matches behaviour when launching Beat Saber.
Use selected Proton's wine instead of system wine, since the wine prefix version may mismatch and cause wine to crash.

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2025

@silentrald
Copy link
Collaborator

@ImSapphire I might double check on the flatpak build if I can install mods with this. There are some weird env vars that get injected there that I assume might break flatpak.

@Mistyttm can you help me verify this if everything's working as expected since your on NixOS.

@Mistyttm
Copy link
Contributor

Mistyttm commented May 9, 2025

@silentrald can already confirm it is my friend, these patches were on the nixos package before Sapphire brought them here. They managed to get it all working

Copy link
Collaborator

@silentrald silentrald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge (ノ^ヮ^)ノ*

@ImSapphire would this needs to be merged first or the other PR from NixOS? Or they are independent to one another.

cc @Mistyttm @Zagrios

@Mistyttm
Copy link
Contributor

@silentrald They are independent as of now. We're pulling from the tagged 1.5.3 release, so when the tagged 1.5.4 release with this code comes out, we can update the package on nixpkgs and remove the patches on our end

nixpkgs version is completely independent from this :)

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Jun 8, 2025

Merging! 🚀
(Sorry for the delay 😅)

@Zagrios Zagrios merged commit dfe63e5 into Zagrios:master Jun 8, 2025
2 checks passed
@ImSapphire ImSapphire deleted the bugfix/nixos-mod-installation branch June 29, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants