Search for definition after navigation #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Wilfred how does this look? |
Contributor
Author
|
Ping @Wilfred |
wyuenho
force-pushed
the
search-after-navigate
branch
from
95eacb2 to
91578fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when helpful is constructing the navigation button in the helpful buffer, it assumes the position of the definition searched is going to remain the same as after finding file. This assumption cannot hold if the user has an
emacs-lisp-mode-hookdefined that changes the buffer size, e.g.(indent-region (point-min) (point-max)), so in order to make sure the point is really pointing at the definition,helpful--navigatewill have to search again.This logic is mostly copied from
help-mode, which does not have the same problem.