[LFC][Integration] Do not snap the vertical position of a render replaced to integral value

https://bugs.webkit.org/show_bug.cgi?id=217885

Reviewed by Antti Koivisto.

Apparently legacy inline layout only snaps text content.

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::constructContent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebCore/ChangeLog

@@ -1,3 +1,15 @@
+2020-10-18  Zalan Bujtas  <[email protected]>
+
+        [LFC][Integration] Do not snap the vertical position of a render replaced to integral value
+        https://bugs.webkit.org/show_bug.cgi?id=217885
+
+        Reviewed by Antti Koivisto.
+
+        Apparently legacy inline layout only snaps text content.
+
+        * layout/integration/LayoutIntegrationLineLayout.cpp:
+        (WebCore::LayoutIntegration::LineLayout::constructContent):
+
 2020-10-18  Zalan Bujtas  <[email protected]>
 
         [LFC][IFC] Inline level boxes are at the incorrect position when line is horizontally aligned

Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp

@@ -155,7 +155,9 @@ void LineLayout::constructContent()
             auto lineBoxLogicalRect = m_inlineFormattingState.lines()[lineIndex].lineBoxLogicalRect();
             runRect.moveBy({ lineBoxLogicalRect.left(), lineBoxLogicalRect.top() });
             // InlineTree rounds y position to integral value, see InlineFlowBox::placeBoxesInBlockDirection.
-            runRect.setY(roundToInt(runRect.y()));
+            auto needsLegacyIntegralPosition = !layoutBox.isReplacedBox();
+            if (needsLegacyIntegralPosition)
+                runRect.setY(roundToInt(runRect.y()));
 
             WTF::Optional<Run::TextContent> textContent;
             if (auto text = lineRun.text())