[LFC][IFC] Inline level boxes are at the incorrect position when line is horizontally aligned

https://bugs.webkit.org/show_bug.cgi?id=217887

Reviewed by Antti Koivisto.

Inline boxes (as opposed to runs) are constructed after the horizontal alignment is computed so their position
already includes the horizontal offset. No need to offset the again at logicalRectForInlineLevelBox.

* layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebCore/ChangeLog

@@ -1,3 +1,16 @@
+2020-10-18  Zalan Bujtas  <[email protected]>
+
+        [LFC][IFC] Inline level boxes are at the incorrect position when line is horizontally aligned
+        https://bugs.webkit.org/show_bug.cgi?id=217887
+
+        Reviewed by Antti Koivisto.
+
+        Inline boxes (as opposed to runs) are constructed after the horizontal alignment is computed so their position
+        already includes the horizontal offset. No need to offset the again at logicalRectForInlineLevelBox.
+
+        * layout/inlineformatting/InlineLineBox.cpp:
+        (WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):
+
 2020-10-18  Zalan Bujtas  <[email protected]>
 
         [LFC][IFC] Add quirks mode for root inline box height stretching

Source/WebCore/layout/inlineformatting/InlineLineBox.cpp

@@ -91,7 +91,7 @@ InlineRect LineBox::logicalRectForInlineLevelBox(const Box& layoutBox) const
         ASSERT(inlineBox->isInlineBox());
         inlineBoxAbsolutelogicalTop += inlineBox->logicalTop();
     }
-    return { inlineBoxAbsolutelogicalTop, m_horizontalAlignmentOffset.valueOr(InlineLayoutUnit { }) + inlineBoxLogicalRect.left(), inlineBoxLogicalRect.width(), inlineBoxLogicalRect.height() };
+    return { inlineBoxAbsolutelogicalTop, inlineBoxLogicalRect.left(), inlineBoxLogicalRect.width(), inlineBoxLogicalRect.height() };
 }
 
 }