Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit 5fabe9e

Browse files
[webkitflaskpy] Create shared library for WebKit's flask tooling
https://bugs.webkit.org/show_bug.cgi?id=218257 <rdar://problem/70736269> Rubber-stamped by Aakash Jain. * Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: (_maybe_add_webkit_python_library_paths): Add webkitcorepy and webkitflaskpy. (_maybe_add_webkitcorepy_path): Renamed _maybe_add_webkit_python_library_paths. * Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/util.py: Moved to webkitflaskpy/util.py. * Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Moved to webkitflaskpy/util_unittest.py. * Scripts/libraries/webkitflaskpy: Added. * Scripts/libraries/webkitflaskpy/MANIFEST.in: Added. * Scripts/libraries/webkitflaskpy/README.md: Added. * Scripts/libraries/webkitflaskpy/setup.py: Added. * Scripts/libraries/webkitflaskpy/webkitflaskpy: Added. * Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py: Added. * Scripts/libraries/webkitflaskpy/webkitflaskpy/util.py: Moved from resultsdpy/flask_support/util.py. * Scripts/libraries/webkitflaskpy/webkitflaskpy/util_unittest.py: Moved from resultsdpy/flask_support/util_unittest.py. * Scripts/webkitpy/test/main.py: (main): Add git-svn-id: http://svn.webkit.org/repository/webkit/trunk@269114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 43721a2 commit 5fabe9e

24 files changed

+175
-31
lines changed

Tools/ChangeLog

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,27 @@
1+
2020-10-28 Jonathan Bedard <[email protected]>
2+
3+
[webkitflaskpy] Create shared library for WebKit's flask tooling
4+
https://bugs.webkit.org/show_bug.cgi?id=218257
5+
<rdar://problem/70736269>
6+
7+
Rubber-stamped by Aakash Jain.
8+
9+
* Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py:
10+
(_maybe_add_webkit_python_library_paths): Add webkitcorepy and webkitflaskpy.
11+
(_maybe_add_webkitcorepy_path): Renamed _maybe_add_webkit_python_library_paths.
12+
* Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/util.py: Moved to webkitflaskpy/util.py.
13+
* Scripts/libraries/resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Moved to webkitflaskpy/util_unittest.py.
14+
* Scripts/libraries/webkitflaskpy: Added.
15+
* Scripts/libraries/webkitflaskpy/MANIFEST.in: Added.
16+
* Scripts/libraries/webkitflaskpy/README.md: Added.
17+
* Scripts/libraries/webkitflaskpy/setup.py: Added.
18+
* Scripts/libraries/webkitflaskpy/webkitflaskpy: Added.
19+
* Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py: Added.
20+
* Scripts/libraries/webkitflaskpy/webkitflaskpy/util.py: Moved from resultsdpy/flask_support/util.py.
21+
* Scripts/libraries/webkitflaskpy/webkitflaskpy/util_unittest.py: Moved from resultsdpy/flask_support/util_unittest.py.
22+
* Scripts/webkitpy/test/main.py:
23+
(main): Add
24+
125
2020-10-28 Sam Weinig <[email protected]>
226

327
Reduce Preference Override Methods: TabsToLinks/SpatialNavigation

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,16 @@
2424
import sys
2525

2626

27-
def _maybe_add_webkitcorepy_path():
28-
# Hopefully we're beside webkitcorepy, otherwise webkitcorepy will need to be installed.
27+
def _maybe_add_webkit_python_library_paths():
28+
# Hopefully we're beside webkit*py libraries, otherwise webkit*py will need to be installed.
2929
libraries_path = os.path.dirname(os.path.dirname(os.path.abspath(os.path.dirname(__file__))))
30-
webkitcorepy_path = os.path.join(libraries_path, 'webkitcorepy')
31-
if os.path.isdir(webkitcorepy_path) and os.path.isdir(os.path.join(webkitcorepy_path, 'webkitcorepy')) and webkitcorepy_path not in sys.path:
32-
sys.path.insert(0, webkitcorepy_path)
30+
for library in ['webkitcorepy', 'webkitflaskpy']:
31+
library_path = os.path.join(libraries_path, library)
32+
if os.path.isdir(library_path) and os.path.isdir(os.path.join(library_path, library)) and library_path not in sys.path:
33+
sys.path.insert(0, library_path)
3334

3435

35-
_maybe_add_webkitcorepy_path()
36+
_maybe_add_webkit_python_library_paths()
3637

3738
try:
3839
from webkitcorepy.version import Version

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/archive_controller.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,11 @@
2626
import time
2727

2828
from flask import abort, jsonify, request, send_file
29-
from resultsdbpy.controller.commit import Commit
3029
from resultsdbpy.controller.commit_controller import uuid_range_for_query, HasCommitContext
3130
from resultsdbpy.controller.configuration import Configuration
3231
from resultsdbpy.controller.configuration_controller import configuration_for_query
3332
from resultsdbpy.controller.suite_controller import time_range_for_query
34-
from resultsdbpy.flask_support.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
33+
from webkitflaskpy.util import AssertRequest, query_as_kwargs, boolean_query
3534

3635

3736
class ArchiveController(HasCommitContext):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/ci_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from resultsdbpy.controller.configuration import Configuration
2626
from resultsdbpy.controller.configuration_controller import configuration_for_query
2727
from resultsdbpy.controller.suite_controller import time_range_for_query
28-
from resultsdbpy.flask_support.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
28+
from webkitflaskpy.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
2929

3030

3131
class CIController(HasCommitContext):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import re
2626

2727
from datetime import datetime
28-
from resultsdbpy.flask_support.util import FlaskJSONEncoder
28+
from webkitflaskpy.util import FlaskJSONEncoder
2929

3030

3131
class Commit(object):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424

2525
from collections import defaultdict
2626
from flask import abort, jsonify, request
27-
from resultsdbpy.flask_support.util import AssertRequest, query_as_kwargs, limit_for_query
2827
from resultsdbpy.model.repository import SCMException
2928
from resultsdbpy.controller.commit import Commit
29+
from webkitflaskpy.util import AssertRequest, query_as_kwargs, limit_for_query
3030

3131

3232
def _find_comparison(commit_context, repository_id, branch, id, uuid, timestamp, priority=min):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
import json
2424

25-
from resultsdbpy.flask_support.util import FlaskJSONEncoder
25+
from webkitflaskpy.util import FlaskJSONEncoder
2626

2727

2828
class Configuration(object):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/configuration_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
2121
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2222

23-
from resultsdbpy.flask_support.util import boolean_query
2423
from resultsdbpy.controller.configuration import Configuration
24+
from webkitflaskpy.util import boolean_query
2525

2626

2727
def configuration_for_query():

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/failure_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from resultsdbpy.controller.configuration import Configuration
2626
from resultsdbpy.controller.configuration_controller import configuration_for_query
2727
from resultsdbpy.controller.suite_controller import time_range_for_query
28-
from resultsdbpy.flask_support.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
28+
from webkitflaskpy.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
2929

3030

3131
class FailureController(HasCommitContext):

Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/suite_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from resultsdbpy.controller.commit_controller import uuid_range_for_query, HasCommitContext
2525
from resultsdbpy.controller.configuration import Configuration
2626
from resultsdbpy.controller.configuration_controller import configuration_for_query
27-
from resultsdbpy.flask_support.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
27+
from webkitflaskpy.util import AssertRequest, query_as_kwargs, limit_for_query, boolean_query
2828

2929

3030
def time_range_for_query():

0 commit comments

Comments
 (0)