Reduce Preference Override Methods: TabsToLinks/SpatialNavigation

https://bugs.webkit.org/show_bug.cgi?id=218288

Reviewed by Tim Horton.

Source/WebKit:

Removes WKPreferencesGet/SetTabToLinksEnabled preference as it duplicates functionality of
WKPreferencesGet/SetTabsToLinks. The former was added for https://bugs.webkit.org/show_bug.cgi?id=95329
but was redundant even at the time. We can now use test header commands for all of its
use cases.

Also removes testing only bundle SPI for enabling spatial navigation which also can be
set via test headers instead.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTabToLinksEnabled): Deleted.
(WKPreferencesGetTabToLinksEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetSpatialNavigationEnabled): Deleted.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setSpatialNavigationEnabled): Deleted.
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setTabToLinksEnabled): Deleted.
(WebKit::WebPage::tabToLinksEnabled const): Deleted.

Source/WTF:

* Scripts/Preferences/WebPreferences.yaml:
Unify TabToLinksEnabled and TabsToLinks. TabToLinksEnabled was added for https://bugs.webkit.org/show_bug.cgi?id=95329
and has never actually been needed.

Tools:

Replace uses of testRunner.overridePreference("WebKitTabToLinksPreferenceKey", ...) and
testRunner.setSpatialNavigationEnabled(...) with test header commands, helping to reduce
the number of different ways we have to override preferences in LayoutTests.

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
(setSpatialNavigationEnabledCallback): Deleted.
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setSpatialNavigationEnabled): Deleted.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
(setWebPreferencesForTestOptions):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setSpatialNavigationEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

Replace uses of testRunner.overridePreference("WebKitTabToLinksPreferenceKey", ...) and
testRunner.setSpatialNavigationEnabled(...) with test header commands, helping to reduce
the number of different ways we have to override preferences in LayoutTests.

* accessibility/mac/caret-browsing-tab-selection.html:
* accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html:
* accessibility/mac/selection-element-tabbing-to-link.html:
* accessibility/mac/selection-notification-focus-change.html:
* accessibility/mac/tab-focus-post-notification.html:
* fast/events/tab-focus-anchor.html:
* fast/events/tab-focus-link-in-canvas.html:
* fast/spatial-navigation/snav-1st-stop.html:
* fast/spatial-navigation/snav-clipped-overflowed-content.html:
* fast/spatial-navigation/snav-container-only-white-space.html:
* fast/spatial-navigation/snav-container-white-space.html:
* fast/spatial-navigation/snav-display-contents-crash.html:
* fast/spatial-navigation/snav-div-overflow-scrol-hidden.html:
* fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
* fast/spatial-navigation/snav-fully-aligned-horizontally.html:
* fast/spatial-navigation/snav-fully-aligned-vertically.html:
* fast/spatial-navigation/snav-hidden-focusable-element.html:
* fast/spatial-navigation/snav-hidden-iframe-zero-size.html:
* fast/spatial-navigation/snav-hidden-iframe.html:
* fast/spatial-navigation/snav-iframe-flattening-simple.html:
* fast/spatial-navigation/snav-iframe-nested.html:
* fast/spatial-navigation/snav-iframe-no-focusable-content.html:
* fast/spatial-navigation/snav-iframe-no-scrollable-content.html:
* fast/spatial-navigation/snav-iframe-recursive-offset-parent.html:
* fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
* fast/spatial-navigation/snav-imagemap-area-not-focusable.html:
* fast/spatial-navigation/snav-imagemap-area-without-image.html:
* fast/spatial-navigation/snav-imagemap-overlapped-areas.html:
* fast/spatial-navigation/snav-imagemap-simple.html:
* fast/spatial-navigation/snav-input.html:
* fast/spatial-navigation/snav-media-elements.html:
* fast/spatial-navigation/snav-multiple-select-focusring.html:
* fast/spatial-navigation/snav-multiple-select-optgroup.html:
* fast/spatial-navigation/snav-multiple-select.html:
* fast/spatial-navigation/snav-offscreen-content.html:
* fast/spatial-navigation/snav-only-clipped-overflow-content.html:
* fast/spatial-navigation/snav-radio-group.html:
* fast/spatial-navigation/snav-radio.html:
* fast/spatial-navigation/snav-search-optimization.html:
* fast/spatial-navigation/snav-simple-content-overflow.html:
* fast/spatial-navigation/snav-single-select-list.html:
* fast/spatial-navigation/snav-single-select.html:
* fast/spatial-navigation/snav-table-traversal.html:
* fast/spatial-navigation/snav-textarea.html:
* fast/spatial-navigation/snav-tiny-table-traversal.html:
* fast/spatial-navigation/snav-two-elements-one-line.html:
* fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
* fast/spatial-navigation/snav-z-index.html:
* fast/spatial-navigation/snav-zero-margin-content.html:
* media/media-controls-accessibility.html:
* media/tab-focus-inside-media-elements.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@269111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

LayoutTests/ChangeLog

@@ -1,3 +1,66 @@
+2020-10-28  Sam Weinig  <[email protected]>
+
+        Reduce Preference Override Methods: TabsToLinks/SpatialNavigation
+        https://bugs.webkit.org/show_bug.cgi?id=218288
+
+        Reviewed by Tim Horton.
+
+        Replace uses of testRunner.overridePreference("WebKitTabToLinksPreferenceKey", ...) and
+        testRunner.setSpatialNavigationEnabled(...) with test header commands, helping to reduce
+        the number of different ways we have to override preferences in LayoutTests.
+
+        * accessibility/mac/caret-browsing-tab-selection.html:
+        * accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html:
+        * accessibility/mac/selection-element-tabbing-to-link.html:
+        * accessibility/mac/selection-notification-focus-change.html:
+        * accessibility/mac/tab-focus-post-notification.html:
+        * fast/events/tab-focus-anchor.html:
+        * fast/events/tab-focus-link-in-canvas.html:
+        * fast/spatial-navigation/snav-1st-stop.html:
+        * fast/spatial-navigation/snav-clipped-overflowed-content.html:
+        * fast/spatial-navigation/snav-container-only-white-space.html:
+        * fast/spatial-navigation/snav-container-white-space.html:
+        * fast/spatial-navigation/snav-display-contents-crash.html:
+        * fast/spatial-navigation/snav-div-overflow-scrol-hidden.html:
+        * fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
+        * fast/spatial-navigation/snav-fully-aligned-horizontally.html:
+        * fast/spatial-navigation/snav-fully-aligned-vertically.html:
+        * fast/spatial-navigation/snav-hidden-focusable-element.html:
+        * fast/spatial-navigation/snav-hidden-iframe-zero-size.html:
+        * fast/spatial-navigation/snav-hidden-iframe.html:
+        * fast/spatial-navigation/snav-iframe-flattening-simple.html:
+        * fast/spatial-navigation/snav-iframe-nested.html:
+        * fast/spatial-navigation/snav-iframe-no-focusable-content.html:
+        * fast/spatial-navigation/snav-iframe-no-scrollable-content.html:
+        * fast/spatial-navigation/snav-iframe-recursive-offset-parent.html:
+        * fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
+        * fast/spatial-navigation/snav-imagemap-area-not-focusable.html:
+        * fast/spatial-navigation/snav-imagemap-area-without-image.html:
+        * fast/spatial-navigation/snav-imagemap-overlapped-areas.html:
+        * fast/spatial-navigation/snav-imagemap-simple.html:
+        * fast/spatial-navigation/snav-input.html:
+        * fast/spatial-navigation/snav-media-elements.html:
+        * fast/spatial-navigation/snav-multiple-select-focusring.html:
+        * fast/spatial-navigation/snav-multiple-select-optgroup.html:
+        * fast/spatial-navigation/snav-multiple-select.html:
+        * fast/spatial-navigation/snav-offscreen-content.html:
+        * fast/spatial-navigation/snav-only-clipped-overflow-content.html:
+        * fast/spatial-navigation/snav-radio-group.html:
+        * fast/spatial-navigation/snav-radio.html:
+        * fast/spatial-navigation/snav-search-optimization.html:
+        * fast/spatial-navigation/snav-simple-content-overflow.html:
+        * fast/spatial-navigation/snav-single-select-list.html:
+        * fast/spatial-navigation/snav-single-select.html:
+        * fast/spatial-navigation/snav-table-traversal.html:
+        * fast/spatial-navigation/snav-textarea.html:
+        * fast/spatial-navigation/snav-tiny-table-traversal.html:
+        * fast/spatial-navigation/snav-two-elements-one-line.html:
+        * fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
+        * fast/spatial-navigation/snav-z-index.html:
+        * fast/spatial-navigation/snav-zero-margin-content.html:
+        * media/media-controls-accessibility.html:
+        * media/tab-focus-inside-media-elements.html:
+
 2020-10-28  Chris Dumez  <[email protected]>
 
         AudioBuffer channels should be neuterable / detachable

LayoutTests/accessibility/mac/caret-browsing-tab-selection.html

@@ -1,4 +1,4 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ TabsToLinks=true ] -->
 <html>
 <head>
     <script src="../../resources/js-test-pre.js"></script>
@@ -12,8 +12,6 @@
     <script>
     description("This tests caret browsing for html select elements.");
     if (window.testRunner) {
-
-        testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
         testRunner.dumpAsText();
 
         if (window.accessibilityController && window.eventSender) {

LayoutTests/accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html

@@ -1,4 +1,4 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ TabsToLinks=true ] -->
 <html>
 <head>
 <script src="../../resources/js-test.js"></script>
@@ -61,7 +61,6 @@
 
     if (window.accessibilityController) {
         jsTestIsAsync = true;
-        testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
 
         accessibilityController.enableEnhancedAccessibility(true);
         webArea = accessibilityController.rootElement.childAtIndex(0);

LayoutTests/accessibility/mac/selection-element-tabbing-to-link.html

@@ -1,4 +1,4 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ TabsToLinks=true ] -->
 <html>
 <head>
 <script src="../../resources/js-test.js"></script>
@@ -55,7 +55,6 @@
 
     if (window.accessibilityController) {
         jsTestIsAsync = true;
-        testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
 
         accessibilityController.enableEnhancedAccessibility(true);
         webArea = accessibilityController.rootElement.childAtIndex(0);

LayoutTests/accessibility/mac/selection-notification-focus-change.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ TabsToLinks=true ] -->
 <html>
     <head>
         <script src="../../resources/js-test-pre.js"></script>
@@ -37,8 +37,6 @@
             }
 
             function runFirstTabMoveTest() {
-                testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
-
                 accessibilityController.enableEnhancedAccessibility(true);
                 webArea = accessibilityController.rootElement.childAtIndex(0);
                 webArea.setBoolAttributeValue("AXCaretBrowsingEnabled", true)

LayoutTests/accessibility/mac/tab-focus-post-notification.html

@@ -1,3 +1,4 @@
+<!DOCTYPE html><!-- webkit-test-runner [ TabsToLinks=true ] -->
 <html>
 <head>
 <script src="../../resources/js-test-pre.js"></script>
@@ -25,8 +26,6 @@
 description("This tests that tabbing focus onto elements will send out notifications");
 
 if (window.testRunner && window.accessibilityController) {
-
-    testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
     accessibilityController.enableEnhancedAccessibility(true);
 
     var count = 0;

LayoutTests/fast/events/tab-focus-anchor.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ TabsToLinks=false ] -->
 <html>
 <head>
 <script>
@@ -17,7 +17,6 @@
 
 if (window.testRunner) {
     testRunner.dumpAsText();
-    testRunner.overridePreference('WebKitTabToLinksPreferenceKey', false);
 }
 
 window.onload = function()

LayoutTests/fast/events/tab-focus-link-in-canvas.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ TabsToLinks=true ] -->
 <html>
 <head>
 <script src="../../resources/js-test-pre.js"></script>
@@ -16,7 +16,6 @@
 
 if (window.testRunner && window.eventSender) {
     testRunner.dumpAsText();
-    testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
 
     document.getElementById('before').focus();
     shouldBe('document.activeElement.id', '"before"');

LayoutTests/fast/spatial-navigation/snav-1st-stop.html

@@ -1,3 +1,4 @@
+<!DOCTYPE html><!-- webkit-test-runner [ TabsToLinks=true SpatialNavigationEnabled=true ] -->
 <html>
   <!--
     This test ensures the correctness of Spatial Navigation (SNav) algorithm from a non-focus scenario.
@@ -21,8 +22,6 @@
 
     if (window.testRunner) {
       testRunner.dumpAsText();
-      testRunner.setSpatialNavigationEnabled(true);
-      testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
       testRunner.waitUntilDone();
     }
 

LayoutTests/fast/spatial-navigation/snav-clipped-overflowed-content.html

@@ -1,3 +1,4 @@
+<!DOCTYPE html><!-- webkit-test-runner [ TabsToLinks=true SpatialNavigationEnabled=true ] -->
 <html>
   <!--
     This test ensures the correctness of a basic aspect of spatial navigation traversal
@@ -48,8 +49,6 @@
 
     if (window.testRunner) {
       testRunner.dumpAsText();
-      testRunner.setSpatialNavigationEnabled(true);
-      testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
       testRunner.waitUntilDone();
     }