Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit 382399f

Browse files
[GTK] Miscellaneous build cleanups
https://bugs.webkit.org/show_bug.cgi?id=184399 Reviewed by Žan Doberšek. .: * Source/cmake/OptionsGTK.cmake: Source/JavaScriptCore: * PlatformGTK.cmake: Source/WebKit: * PlatformGTK.cmake: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@230996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent b6105dd commit 382399f

File tree

6 files changed

+27
-6
lines changed

6 files changed

+27
-6
lines changed

ChangeLog

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
2018-04-25 Michael Catanzaro <[email protected]>
2+
3+
[GTK] Miscellaneous build cleanups
4+
https://bugs.webkit.org/show_bug.cgi?id=184399
5+
6+
Reviewed by Žan Doberšek.
7+
8+
* Source/cmake/OptionsGTK.cmake:
9+
110
2018-04-24 Leo Balter <[email protected]>
211

312
Land test262 test results associated with Test262 runner

Source/JavaScriptCore/ChangeLog

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
2018-04-25 Michael Catanzaro <[email protected]>
2+
3+
[GTK] Miscellaneous build cleanups
4+
https://bugs.webkit.org/show_bug.cgi?id=184399
5+
6+
Reviewed by Žan Doberšek.
7+
8+
* PlatformGTK.cmake:
9+
110
2018-04-24 Keith Miller <[email protected]>
211

312
fromCharCode is missing some exception checks

Source/JavaScriptCore/PlatformGTK.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ if (ENABLE_INTROSPECTION)
4040
endif ()
4141

4242
add_definitions(-DSTATICALLY_LINKED_WITH_WTF)
43-
add_definitions(-DLIBDIR="${LIB_INSTALL_DIR}")
4443
add_definitions(-DJSC_COMPILATION)
4544

4645
list(APPEND JavaScriptCore_LIBRARIES

Source/WebKit/ChangeLog

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
2018-04-25 Michael Catanzaro <[email protected]>
2+
3+
[GTK] Miscellaneous build cleanups
4+
https://bugs.webkit.org/show_bug.cgi?id=184399
5+
6+
Reviewed by Žan Doberšek.
7+
8+
* PlatformGTK.cmake:
9+
110
2018-04-25 Dean Jackson <[email protected]>
211

312
Make a better flag for system preview, and disable it where necessary

Source/WebKit/PlatformGTK.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ add_definitions(-DBUILDING_WEBKIT)
1818
add_definitions(-DWEBKIT2_COMPILATION)
1919
add_definitions(-DWEBKIT_DOM_USE_UNSTABLE_API)
2020

21-
add_definitions(-DLIBEXECDIR="${CMAKE_INSTALL_FULL_LIBEXECDIR}")
2221
add_definitions(-DPKGLIBEXECDIR="${LIBEXEC_INSTALL_DIR}")
2322
add_definitions(-DLOCALEDIR="${CMAKE_INSTALL_FULL_LOCALEDIR}")
2423
add_definitions(-DLIBDIR="${LIB_INSTALL_DIR}")
25-
add_definitions(-DDATADIR="${CMAKE_INSTALL_FULL_DATADIR}")
2624

2725
if (NOT DEVELOPER_MODE AND NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
2826
WEBKIT_ADD_TARGET_PROPERTIES(WebKit LINK_FLAGS "-Wl,--version-script,${CMAKE_CURRENT_SOURCE_DIR}/webkitglib-symbols.map")

Source/cmake/OptionsGTK.cmake

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ set(LIB_INSTALL_DIR "${CMAKE_INSTALL_FULL_LIBDIR}" CACHE PATH "Absolute path to
1313
set(EXEC_INSTALL_DIR "${CMAKE_INSTALL_FULL_BINDIR}" CACHE PATH "Absolute path to executable installation directory")
1414
set(LIBEXEC_INSTALL_DIR "${CMAKE_INSTALL_FULL_LIBEXECDIR}/webkit2gtk-${WEBKITGTK_API_VERSION}" CACHE PATH "Absolute path to install executables executed by the library")
1515

16-
set(DATA_BUILD_DIR "${CMAKE_BINARY_DIR}/share/${WebKit_OUTPUT_NAME}")
17-
set(DATA_INSTALL_DIR "${CMAKE_INSTALL_DATADIR}/webkitgtk-${WEBKITGTK_API_VERSION}")
1816
set(WEBKITGTK_HEADER_INSTALL_DIR "${CMAKE_INSTALL_INCLUDEDIR}/webkitgtk-${WEBKITGTK_API_VERSION}")
1917
set(INTROSPECTION_INSTALL_GIRDIR "${CMAKE_INSTALL_FULL_DATADIR}/gir-1.0")
2018
set(INTROSPECTION_INSTALL_TYPELIBDIR "${LIB_INSTALL_DIR}/girepository-1.0")
@@ -383,7 +381,6 @@ set(FORWARDING_HEADERS_WEBKIT2GTK_DIR ${FORWARDING_HEADERS_DIR}/webkit2gtk)
383381
set(FORWARDING_HEADERS_WEBKIT2GTK_EXTENSION_DIR ${FORWARDING_HEADERS_DIR}/webkit2gtk-webextension)
384382

385383
set(JavaScriptCore_PKGCONFIG_FILE ${CMAKE_BINARY_DIR}/Source/JavaScriptCore/javascriptcoregtk-${WEBKITGTK_API_VERSION}.pc)
386-
set(WebKit_PKGCONFIG_FILE ${CMAKE_BINARY_DIR}/Source/WebKitLegacy/gtk/webkitgtk-${WEBKITGTK_API_VERSION}.pc)
387384
set(WebKit2_PKGCONFIG_FILE ${CMAKE_BINARY_DIR}/Source/WebKit/webkit2gtk-${WEBKITGTK_API_VERSION}.pc)
388385
set(WebKit2WebExtension_PKGCONFIG_FILE ${CMAKE_BINARY_DIR}/Source/WebKit/webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}.pc)
389386

0 commit comments

Comments
 (0)