Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit b6105dd

Browse files
[Win] Crash under WebCore::SimpleLineLayout::generateLineBoxTree
https://bugs.webkit.org/show_bug.cgi?id=184953 This is possibly a MSVC compiler bug, since a simple rearrangement of the code fixes the crash. The crash is only happening in release builds, which also is an indication of this being a compiler issue. Reviewed by Zalan Bujtas. No new tests, covered by existing tests. * rendering/SimpleLineLayoutFunctions.cpp: (WebCore::SimpleLineLayout::generateLineBoxTree): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@230995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 5237a66 commit b6105dd

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

Source/WebCore/ChangeLog

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
2018-04-25 Per Arne Vollan <[email protected]>
2+
3+
[Win] Crash under WebCore::SimpleLineLayout::generateLineBoxTree
4+
https://bugs.webkit.org/show_bug.cgi?id=184953
5+
6+
This is possibly a MSVC compiler bug, since a simple rearrangement of the code fixes the crash.
7+
The crash is only happening in release builds, which also is an indication of this being a
8+
compiler issue.
9+
10+
Reviewed by Zalan Bujtas.
11+
12+
No new tests, covered by existing tests.
13+
14+
* rendering/SimpleLineLayoutFunctions.cpp:
15+
(WebCore::SimpleLineLayout::generateLineBoxTree):
16+
117
2018-04-25 Dean Jackson <[email protected]>
218

319
Make a better flag for system preview, and disable it where necessary

Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,8 @@ void generateLineBoxTree(RenderBlockFlow& flow, const Layout& layout)
353353
}
354354

355355
// Finish setting up the rootline.
356-
auto firstRun = *range.begin();
356+
auto iter = range.begin();
357+
auto firstRun = *iter;
357358
rootLineBox.setLogicalLeft(firstRun.logicalLeft());
358359
rootLineBox.setLogicalWidth(lineWidth);
359360
auto lineTop = firstRun.rect().y();

0 commit comments

Comments
 (0)