Skip to content

Support links in using file directive (implements #1328) #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ivan-klass
Copy link

@ivan-klass ivan-klass commented May 15, 2025

Scala Tooling Spree 15.05

see #1328

Co-authored-by: Michał Pawlik <[email protected]>
Co-authored-by: tgodzik <[email protected]>
@ivan-klass
Copy link
Author

ivan-klass commented May 16, 2025

git+ssh is not supported by coursier and should be addressed there - currently only HTTP is assumed:

coursier.cache.internal.Downloader.Blocking.doDownload

@ivan-klass
Copy link
Author

@majk-p @tgodzik It works! Indeed, dependencies are resolved recursively already.

out/test.scala:

//> using file https://raw.githubusercontent.com/softwaremill/sttp/refs/heads/master/examples/src/main/scala/sttp/client4/examples/json/GetAndParseJsonCatsEffectCirce.scala

./mill 'cli[3.3.6].run' out/test.scala:

Got response code: 200
Right(HttpBinResponse(87.116.164.191,Map(Accept-Encoding -> gzip, deflate, Host -> httpbin.org, User-Agent -> Java-http-client/17.0.13, X-Amzn-Trace-Id -> Root=1-6826f31e-7030221a5448052d12774af8)))

@ivan-klass ivan-klass marked this pull request as ready for review May 16, 2025 08:16
@Gedochao Gedochao self-requested a review May 16, 2025 12:55
@Gedochao Gedochao self-assigned this May 16, 2025
@Gedochao
Copy link
Contributor

Note: need to fix formatting & regenerate reference docs for the CI to pass.
https://github.com/VirtusLab/scala-cli/blob/main/CONTRIBUTING.md

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to skip git+ssh IMO, we don't support that anywhere else, either.
The solution looks good so far, just need to address the TODOs and add tests

As for tests, maybe can reuse stuff from scala.cli.integration.RunGistTestDefinitions.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we just need a test at this point.
As noted earlier, you should be able to reuse stuff from scala.cli.integration.RunGistTestDefinitions.

@ivan-klass
Copy link
Author

@Gedochao thanks, please take a look on the test added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

//> using file directives should allow URLs and git repository paths
2 participants