Fixes binaryninja-api#6825

[plafosse]

we weren't handling zero offsets from structures at all it looks like.
#6825

[CLAassistant]

All committers have signed the CLA.

[Copilot]

Pull Request Overview

This PR addresses issue binaryninja-api#6825 by refining the handling of zero offsets in structure member evaluation. Key changes include:

• Replacing the dereference flag with a member resolution flag (memberResolved)
• Updating token rendering logic to always use instr.size for type casts
• Revising pointer arithmetic handling to only append arithmetic tokens when the offset is non-zero

Comments suppressed due to low confidence (3)

lang/c/pseudoc.cpp:2467

• [nitpick] Consider renaming 'memberResolved' to 'isMemberResolved' for improved clarity and consistency with boolean naming conventions.

			bool memberResolved = false;

lang/c/pseudoc.cpp:2520

• Ensure that always using 'instr.size' instead of conditionally selecting a size value is the intended design for the type cast, as this change may affect the formatting of the resulting expression.

				AppendSizeToken(instr.size, true, tokens);

lang/c/pseudoc.cpp:2536

• Confirm that the decision to only append pointer arithmetic tokens when offset is non-zero fully addresses the zero offset issue without unintended side effects in pointer arithmetic scenarios.

			if (offset != 0)