Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
VideoSampleResourceandAudioSampleResource, a way to create a video or audio sample that's backed by a custom data resource not covered by the base WebCodecs API. The intention is that you can use this to efficiently connect Mediabunny with other sample sources, for example a sample backed by an FFmpeg AVFrame, without needing to copy any data or convert to Uint8Array first.Things to figure out:
allocationSizeandcopyTocan get very complex to implement properly. Is the burden pushed fully onto the implementor of the resource, or does Mediabunny help out? I feel both must be possible: For max efficiency, the resource should be able to handle it itself, but if it's lazy, it should be able to communicate that too.VideoFrameroute, which is okay in browser environments. But, how does this extend to server environments where the canvas API needs to be polyfilled?