chore(AI): newStrategyModal flag cleanup #10912
Merged
+71
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
gastonfournier
approved these changes
Nov 4, 2025
Comment on lines
225
to
226
| - Add newStrategyModal flag ([#10629](https://github.com/Unleash/unleash/issues/10629)) | ||
|
|
There was a problem hiding this comment.
I think we should not modify the changelog
There was a problem hiding this comment.
Oops, you're completely right, I missed that. Fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the newStrategyModal flag. These changes were automatically generated by AI and should be reviewed carefully.
Fixes #10911
🧹 AI Flag Cleanup Summary
This change removes the newStrategyModal feature flag, making the new "Add
strategy" modal the default and only experience for adding strategies to a
feature.
I've removed the flag checks and the legacy code paths for the old strategy
menu. The FeatureStrategyMenu component is now simplified to only render the new
modal experience. I have also removed the flag from backend configurations and
frontend interfaces.
🚮 Removed
• Feature Flag: newStrategyModal flag definition and configuration from
experimental.ts, server-dev.ts, and uiConfig.ts.
• Conditional Logic: All checks for the newStrategyModal flag in
FeatureStrategyMenu.tsx.
• Legacy Components: The old strategy menu (LegacyFeatureStrategyMenuCards) and
related dialogs (LegacyReleasePlanReviewDialog) have been removed from
FeatureStrategyMenu.tsx.
• Unused Code: Unused state variables, functions
(openDefaultStrategyCreationModal, openReleasePlans), and imports related to
the legacy strategy menu have been cleaned up.
🛠 Kept
• New "Add strategy" modal: The new modal for adding strategies is now the only
implementation. Its user experience is preserved and made default.
📝 Why
The newStrategyModal feature has been completed, and the decision was to keep
the new user experience. This cleanup removes the complexity of maintaining two
different UI paths for adding strategies, making the code cleaner and easier to
maintain.