Update Analytics to use new API #6221
Open
+75
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamziaa
commented
Jul 16, 2025
| @@ -26,6 +28,8 @@ jobs: | |||
| - uses: actions/setup-dotnet@v4 | |||
| with: | |||
| dotnet-version: '8.0.202' | |||
| - name: Clean dotnet shared memory | |||
| run: sudo rm -rf /tmp/.dotnet/shm | |||
There was a problem hiding this comment.
any objections to do a cleanup first? Anything else is using /tmp/.dotnet/shm?
maryamziaa
commented
Jul 17, 2025
| @@ -90,7 +51,7 @@ internal static bool EnableAnalytics() | |||
| s_TrainingSessionGuid = Guid.NewGuid(); | |||
| } | |||
|
|
|||
| return s_EventsRegistered; | |||
| return true; | |||
There was a problem hiding this comment.
EnableAnalytics() always returns true if the conditions apply, i.e. UNITY_EDITOR && MLA_UNITY_ANALYTICS_MODULE && ENABLE_CLOUD_SERVICES_ANALYTICS. Is that OK? We don't RegisterEvent anymore in the new API.
| { | ||
| s_SentModels = new HashSet<ModelAsset>(); | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
EnableAnalytics() always returns true if the conditions apply, i.e. UNITY_EDITOR && MLA_UNITY_ANALYTICS_MODULE && ENABLE_CLOUD_SERVICES_ANALYTICS. Is that OK? We don't RegisterEvent anymore in the new API.
antoine-agthe-unity
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
The old analytics API has been deprecated. This PR updates the analytics implementation to use the new API.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments