Skip to content

Feat: Misc Fixes & Recruitment Service #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 3, 2023
Merged

Conversation

SimplyJpk
Copy link
Member

Description 📝

Continued clean-up, and fix a couple small issues introduced by recuirtment service.

  • Fix issue with Recruitment ignoring any tags, not just ones we want
  • Fix issue with rolegroup identifier not returning correct result
  • Fix bug introduced from deprecated xml reader
  • Impr: RecruitService locks a channel after the edit period has passed
  • Impr: Increase max reminders to 10 for the crazy people
  • Impr: RecruitmentService will delete any messages by non-mods in recruitment channels to prevent cross-post while editing is active.

Link to Issue🔗

#212

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@SimplyJpk SimplyJpk added the enhancement New feature or request label Aug 3, 2023
@SimplyJpk
Copy link
Member Author

Should be fine to merge unless other people find more issues

@Pierre-Demessence Pierre-Demessence merged commit 93115da into dev Aug 3, 2023
@Pierre-Demessence Pierre-Demessence deleted the feat/misc-fixes branch August 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants