Skip to content

Feat: Misc Fixes & Recruitment Channel BabySitter #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 2, 2023

Conversation

SimplyJpk
Copy link
Member

@SimplyJpk SimplyJpk commented Jul 29, 2023

Description 📝

Fairly basic clean-up of the repo, a number of simple fixes have been applied.

  • Added some additional information to the ReadMe regarding Docker and getting the project to run, and remove other misc details that had long since been abandoned.
  • Replaced use of Discriminator with DisplayName "NickName (aka Username)" where possible, otherwise use of DisplayName (which will show NickName as preference, with Username shown if no Nick)
  • Added some additional checks during database startup to prevent some issues with docker
  • Track Deleted and Edited messages better, smaller format, include edited messages if still exists in cached results, but also includes a small message any time a message is edited to maintain proof of change if required.
  • Introduced a Bool in the settings to easily enable/disable the previously merged UnityHelp BabySitter service so that if it doesn't work as intended after all this time since implementation, it can at least be disabled without rolling-back.
  • Expanded Logger enum to support some of our own Severity types, mostly for debugging but a green "Positive" and a darker yellow "LowWarning" for more ignorable issues.
  • Fix issues (hopefully) with the Welcome service
  • Add settings for UserRoleService which we don't use so it uses less processing and doesn't latch into more gateway events.
  • Added a utility method to see the ID of tags in forum posts so that they're easier to identify. Discord doesn't give us a way to see these without bot assistance.

Big Changes

  • RecruitmentService made to babysit the recruitment channel, it opperates under the expectation that deleting messages is fair-game and that failure to meet guidelines is deletable. It follows pretty simple rules, with 2 main regex checks for new threads in the relevant channels.

Match Currency: (?:\$\s*\d+|\d+\s*\$|\d*\s*(?:USD|£|pounds|€|EUR|euro|euros|GBP))
Was Rev-Share mentioned: \b(?:rev-share|revshare|rev share)\b

Rev-Share isn't a "deletable" offense if a price was included in the message, but I feel the notice alone should help guide users to make decisions better. ie; avoid potential rev-share.

I've included some screenshots of basic intended functionality, however the wording of some of these have changed to be more straight forward.
Discord_4Uxev174WR
Discord_nWY13gIjJZ
Discord_SpMS2pqbx8
Discord_0aCbBrGDwQ

Link to Issue🔗

#212

SimplyJpk added 19 commits July 25, 2023 22:30
I'm still unsure of the actual bug, but this should hopefully self-rectify by restarting the service when it crashes and just removing the last to update user. With a bit more logging involved.
- Positive showing a green message in logs
- LowWarning being a dark yellow for more ignorable warnings

These can be cast down to normal LogSeverity, info for positive and warning for lowwarning.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SimplyJpk
Copy link
Member Author

This should be fine to merge, fixs a number of smaller and larger issues. I've made the changes required for the stagging server setting. I'll eventually do another PR with dev into main once we've got a couple people to at least try use the stagging recruitment channel.

@SimplyJpk SimplyJpk added the enhancement New feature or request label Aug 1, 2023
@Pierre-Demessence Pierre-Demessence merged commit 66b6b1a into dev Aug 2, 2023
@Pierre-Demessence Pierre-Demessence deleted the feat/misc-fixes branch August 2, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants