forked from Invertex/UDHBot
-
Notifications
You must be signed in to change notification settings - Fork 8
Feat: Misc Fixes & Recruitment Channel BabySitter #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a common format
…name and nick in logs
I'm still unsure of the actual bug, but this should hopefully self-rectify by restarting the service when it crashes and just removing the last to update user. With a bit more logging involved.
- Positive showing a green message in logs - LowWarning being a dark yellow for more ignorable warnings These can be cast down to normal LogSeverity, info for positive and warning for lowwarning.
Kudos, SonarCloud Quality Gate passed! |
This should be fine to merge, fixs a number of smaller and larger issues. I've made the changes required for the stagging server setting. I'll eventually do another PR with dev into main once we've got a couple people to at least try use the stagging recruitment channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fairly basic clean-up of the repo, a number of simple fixes have been applied.
Big Changes
Match Currency:
(?:\$\s*\d+|\d+\s*\$|\d*\s*(?:USD|£|pounds|€|EUR|euro|euros|GBP))
Was Rev-Share mentioned:
\b(?:rev-share|revshare|rev share)\b
Rev-Share isn't a "deletable" offense if a price was included in the message, but I feel the notice alone should help guide users to make decisions better. ie; avoid potential rev-share.
I've included some screenshots of basic intended functionality, however the wording of some of these have changed to be more straight forward.




Link to Issue🔗
#212