Skip to content

fixed preview workflow and added current version in navbar! #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 6, 2024

Conversation

shravanngoswamii
Copy link
Member

  1. Now, previews will not get deleted until PR is either merged or closed!
  2. Nav bar have current version along with a link to changelog and versions file!
    Screenshot 2024-07-02 180304

closes #473

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Preview the changes: https://turinglang.org/docs/pr-previews/488, Please avoid using the search feature and navigation bar in PR previews!

@yebai
Copy link
Member

yebai commented Jul 2, 2024

Thanks, @shravanngoswamii -- it looks good; can you remove the relevant links in the left navigation bar now that they are in the top menu?

@shravanngoswamii
Copy link
Member Author

shravanngoswamii commented Jul 2, 2024

can you remove the relevant links in the left navigation bar now that they are in the top menu?

That's nice but if we do not keep them in sidebar then sidebar will not be there when someone visits changelog or versions file, Is that fine?

@yebai
Copy link
Member

yebai commented Jul 2, 2024

That's nice but if we do not keep them in sidebar then sidebar will not be there when someone visits changelog or versions file, Is that fine?

See quarto-dev/quarto-cli#3951 (reply in thread)

@shravanngoswamii
Copy link
Member Author

shravanngoswamii commented Jul 6, 2024

@yebai It's done!

Now, we just have to mention minor version in _quarto.yml like v0.32, v0.33 and it will automatically detect the latest bug-fix of that version and publishes site to it and if the version is latest then it publishes site to latest bug-fix version!
If the version in _quarto.yml is old and someone opens a PR, then vcheck.yml will suggest changing to latest in PR! I have changed the suggestion workflow because the previous one is not working properly, it was suggesting the lines that are not even changed!

See shravanngoswamii#83 for our example of our current suggestion workflow!

Edit: only issue is, if we update any old version, then PR should be from some branch of original repo and not a fork!

@shravanngoswamii
Copy link
Member Author

I have opened a PR for library.qmd in our main site's repo — TuringLang/turinglang.github.io#82

@yebai yebai merged commit b4d5b5b into TuringLang:master Jul 6, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Jul 6, 2024
@yebai
Copy link
Member

yebai commented Jul 6, 2024

Many thanks @shravanngoswamii!

@shravanngoswamii
Copy link
Member Author

It's my pleasure, I have learned a lot of things while making Turing's site, so thanks a lot to you for this opportunity!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR-Preview gets deleted after any commit outside PR
2 participants