Fix evalAndReturn with comments at the bottom of a script #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because beepbox's script: https://cdn.jsdelivr.net/npm/[email protected]/global/beepbox_synth.min.js has a sourceMappingURL comment at the bottom for whatever reason, causing it to become //# sourceMappingURL=beepbox_synth.min.js.map;return beepbox; This is obviously going to break and might also be the case with other libraries too, hot just beepbox. Ported from AmpMod: https://codeberg.org/ampmod/ampmod/commit/0daf1021bdc8e67a1f0d08b91ce500605fcaa711
supervoidcoder
added a commit
to OmniBlocks/scratch-vm
that referenced
this pull request
Dec 24, 2025
Fix evalAndReturn with comments at the bottom of a script (TurboWarp#322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because beepbox's script:
https://cdn.jsdelivr.net/npm/[email protected]/global/beepbox_synth.min.js has a sourceMappingURL comment at the bottom for whatever reason, causing it to become
//# sourceMappingURL=beepbox_synth.min.js.map;return beepbox; This is obviously going to break and might also be the case with other libraries too, hot just beepbox.
So this PR changes it to add a newline before the
returnand also adds a semicolon after the return for compatibility with old js engines that don't support automatic semicolon injection.Ported from AmpMod:
https://codeberg.org/ampmod/ampmod/commit/0daf1021bdc8e67a1f0d08b91ce500605fcaa711
I mostly made it specifically for AmpMod but it will definitely be useful for others who don't understand why evalAndReturn doesn't work sometimes.