Optimized npm installation size #585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we now use GitHub actions instead of travis - we don't use grunt anymore
- created a separate package.json for app dependencies - removed `uuid` in favor of `crypto.randomUUID` - added explicit dependency on handlebars (previously came from express-hbs) - node_modules went from ~168MB to ~72MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge strategy: rebase
uuidin favor ofcrypto.randomUUIDManual testing: Ran the app and uploaded a fixture, getting proper results.
Missing tests: Didn't test with Sentry, or that the Dockerfile works
Also: Not sure if the Renovate config needs to be picked up, or if it will automatically find app/package.json