Skip to content

feat: widen tonic dependency to >=0.13, <0.15 to support tonic 0.14#77

Open
mstyura wants to merge 1 commit into
TrueLayer:mainfrom
mstyura:tonic-0.14
Open

feat: widen tonic dependency to >=0.13, <0.15 to support tonic 0.14#77
mstyura wants to merge 1 commit into
TrueLayer:mainfrom
mstyura:tonic-0.14

Conversation

@mstyura

@mstyura mstyura commented Jun 21, 2026

Copy link
Copy Markdown

Support tonic 0.14 alongside 0.13

Addresses #68: Widens ginepro's tonic requirement to >=0.13, <0.15 so downstream users can build against either 0.13 or 0.14.

Changes

  • ginepro: widen tonic to >=0.13, <0.15 and drop the prost feature (removed in 0.14; ginepro never used the prost codec, so it's a no-op on 0.13).
  • shared_proto / tests: move to tonic 0.14, which splits prost codegen into separate crates (tonic-build -> tonic-prost-build, plus tonic-prost).
  • CI: add a tonic-0_13-check job that compiles ginepro against the 0.13 lower bound, so both ends of the range are covered (0.14 via the existing test suite, 0.13 via this check).

Verification

  • cargo check --workspace --all-features passes on 0.14.
  • ginepro compiles clean against tonic 0.13.1 with both tls-ring and tls-aws-lc.

@mstyura mstyura requested a review from a team as a code owner June 21, 2026 11:05
@palfrey

palfrey commented Jun 26, 2026

Copy link
Copy Markdown

Any thoughts here @skos-ninja ? Happy to help with testing if needed

@palfrey

palfrey commented Jun 29, 2026

Copy link
Copy Markdown

@mstyura. Doesn't build. Needs one of the tls-* features from tonic.

error[E0432]: unresolved import `tonic::transport::ClientTlsConfig`
 --> external/rules_rs++crate+crates__github.com_mstyura_ginepro_d08cdeff/ginepro/src/service_probe.rs:7:5
  |
7 |     ClientTlsConfig,
  |     ^^^^^^^^^^^^^^^ no `ClientTlsConfig` in `transport`

@mstyura

mstyura commented Jun 30, 2026

Copy link
Copy Markdown
Author

@palfrey could you please share what was exact command you've used to run build?

@palfrey

palfrey commented Jul 1, 2026

Copy link
Copy Markdown

I hit this in the middle of TraceMachina/nativelink#2487 so slightly fiddly to pull it out of there.

OTOH, if you install rust-script the following demonstrates the problem

#!/usr/bin/env rust-script
//! ```cargo
//! [dependencies]
//! ginepro = { git = "https://github.com/mstyura/ginepro", rev = "d08cdeff6300edfb46204b3b9fbde3f3355db35f", default-features = false }
//! ```
fn main() {
    
}

@palfrey

palfrey commented Jul 1, 2026

Copy link
Copy Markdown

Ah, I think the problem is my use of default-features = false. No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants