Backport of Redis webhook List operations #7810
Merged
+54
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using Watch() for non-paginated List() calls in the webhook registry. Watch() holds a Redis connection for the entire transaction duration, which contributes to connection spikes during high traffic. When pagination is not required (the common case for handleUp), we now use ReadOnlyClient() directly, matching the pattern used in other registries (packages/redis, pubsub/redis).
github-actions
bot
added
c/application server
halimi
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the backport of the changes approved in https://github.com/TheThingsIndustries/lorawan-stack/pull/4793
@halimi I noticed that the implementation in this repository already had the separation between a paginated request and a get all items request. Which leads me to believe that the changes that were present here were to not propagated to the enterprise repository.
This PR only seeks to make the code consistent.
Additionally the used of the
LockedWatchwas dropped in favor of only usingWatch.