Skip to content

Fix invalid workflow in CLI telemetry #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v3.34
Choose a base branch
from

Conversation

nicholaspcr
Copy link
Contributor

@nicholaspcr nicholaspcr commented May 11, 2025

Summary

Closes #7610

Changes

  • Remove the panic from CLI telemetry workflow
  • Add cache folder creation in Dockerfile

Testing

Steps

Found out that running the Dockerfile in a linux machine causes the cli to panic due to telemetry being enabled. Added the cache folder and now the cli is running properly.

Regressions

Notes for Reviewers

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added this to the v3.35.0 milestone May 11, 2025
@nicholaspcr nicholaspcr self-assigned this May 11, 2025
@nicholaspcr nicholaspcr added the bug Something isn't working label May 11, 2025
@nicholaspcr nicholaspcr force-pushed the fix/cli-telemetry-workflow branch 2 times, most recently from b29cff5 to 066f836 Compare May 26, 2025 21:52
@nicholaspcr nicholaspcr force-pushed the fix/cli-telemetry-workflow branch from 066f836 to ecd2c88 Compare May 27, 2025 12:57
@nicholaspcr nicholaspcr marked this pull request as ready for review May 27, 2025 12:57
@nicholaspcr nicholaspcr requested a review from a team as a code owner May 27, 2025 12:57
@nicholaspcr nicholaspcr requested a review from halimi May 27, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI login error / panic: runtime error: invalid memory address or nil pointer dereference
2 participants