-
Notifications
You must be signed in to change notification settings - Fork 80.6k
Complete the css-exercises #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
malvin149
wants to merge
16
commits into
TheOdinProject:main
Choose a base branch
from
malvin149:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit index.html Added style to div via external css, p via the internal css and button via inline css.
style.css Added class of description and cool to the three odd elements div 1 and 2 with an ID of even-one even-two respectively. Applied the styling to the selectors in the style sheet accordingly.
Added solutions to chaining selectors and added .vscode folder to .gitignore as i did not want to push this settings to the upstream.
Experiment with both type and class selectors for this project and commented out the class descendant combinators.
- Move grouped selectors for para down below .small-para - Use ID selector #confirm-button to target the confirm button - Chain type and class selector to target the div with child class
- Center all items vertically inside the header - Insert two divs as a container for items on the right and items on the left
Modify index.html and style.css files
- Wrap the header close btn text and buttons in a container for flex. Apply flex: 1, to make container take up remaining space - Wrap the buttons in a container to align the two buttons horizontally. - Use gaps for consistent spacing. - Encompass the close button in the header div.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.01-flex-center: Update self check
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section