algorithm : Added Quick Select algorithm #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > ### Describe your change: > * [x] Add an algorithm? > * [ ] Fix a bug or typo in an existing algorithm? > * [ ] Documentation change? > > ### Checklist: > * [x] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md). > * [x] This pull request is all my own work -- I have not plagiarized. > * [x] I know that pull requests will not be merged if they fail the automated tests. > * [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. > * [x] All new JavaScript files are placed inside an existing directory. > * [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. > **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not > * [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. > * [x] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.
Owais28
changed the title
Panquesito7
reviewed
Sep 25, 2022
appgurueu
reviewed
Sep 25, 2022
|
|
||
| const QuickSelect = (items: Array<number>, kth: number): number => { | ||
| // eslint-disable-line no-unused-vars | ||
| if (kth < 1 || kth > items.length) { |
Contributor
There was a problem hiding this comment.
Consider making kth 0-based for consistency with JS.
- removed extra unused configurations
Contributor
|
Please keep the |
Contributor
Author
|
I have reverted the previous commit (17b48fd) |
appgurueu
reviewed
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change: