chore: update codecov/codecov-action to v4
#670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 292 292
Lines 23258 23258
=======================================
Hits 22022 22022
Misses 1236 1236 ☔ View full report in Codecov by Sentry. |
siriak
reviewed
Feb 2, 2024
siriak
reviewed
Feb 2, 2024
vil02
force-pushed
the
update_codecov_action_to_v4
branch
from
ceba78a to
1ba8b44
Compare
|
@siriak: I think you can merge it. My strong conjecture is that the push will go through the upload with token branch. |
siriak
approved these changes
Feb 2, 2024
|
@siriak thanks! I just checked, everything works as expected. |
This was referenced Feb 2, 2024
This was referenced Apr 4, 2024
Open
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toneless uploads to codecov are no longer supported. This PR updates
codecov/codecov-actiontov4and changes the upload workflow in such a way that:Before merge: please make sure to add the token as
CODECOV_TOKENinto the repo secrets. (Token was added)It seems that both of the branches work: