Skip to content

hill_cipher.py: Use int() to gracefully deal with float input #12833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 7, 2025

Describe your change:

Use int(num) instead of round(num) to workaround ruff rule ruf057 unnecessary-round.


  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@cclauss cclauss requested a review from dhruvmanila July 7, 2025 08:15
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 7, 2025
@cclauss cclauss enabled auto-merge (squash) July 7, 2025 08:17
@cclauss cclauss mentioned this pull request Jul 7, 2025
15 tasks
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call seems unnecessary because the type of num is annotated as int as discussed previously. I leave this up to you on whether you want to continue with this approach or update the type annotation to reflect the function contract.

@cclauss cclauss merged commit 5c05335 into master Jul 7, 2025
6 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jul 7, 2025
@cclauss cclauss deleted the workaround-for-ruff-rule-RUF057-unnecessary-round branch July 7, 2025 08:37
@cclauss
Copy link
Member Author

cclauss commented Jul 7, 2025

The num parameter here should be an int. Python will not prevent the caller from breaking that rule.

Using int(num) instead of round(num) ensures the function remains well-behaved in the face of garbage input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants