-
-
Notifications
You must be signed in to change notification settings - Fork 47k
Add radix2 FFT #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add radix2 FFT #1166
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a2b0940
Add radix2 FFT
KirilBangachev 9737b43
Rename radix2_FFT.py to radix2_fft.py
KirilBangachev 0e87742
Update radix2_fft printing
KirilBangachev 611f6aa
__str__ method update
KirilBangachev d932f15
Turned the tests into doctests
KirilBangachev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,202 @@ | ||
""" | ||
Fast Polynomial Multiplication using radix-2 fast Fourier Transform. | ||
|
||
Reference: | ||
https://en.wikipedia.org/wiki/Cooley%E2%80%93Tukey_FFT_algorithm#The_radix-2_DIT_case | ||
|
||
For polynomials of degree m and n the algorithms has complexity | ||
O(n*logn + m*logm) | ||
|
||
The main part of the algorithm is split in two parts: | ||
1) __DFT: We compute the discrete fourier transform (DFT) of A and B using a | ||
bottom-up dynamic approach - | ||
2) __multiply: Once we obtain the DFT of A*B, we can similarly | ||
invert it to obtain A*B | ||
|
||
The class FFT takes two polynomials A and B with complex coefficients as arguments; | ||
The two polynomials should be represented as a sequence of coefficients starting | ||
from the free term. Thus, for instance x + 2*x^3 could be represented as | ||
[0,1,0,2] or (0,1,0,2). The constructor adds some zeros at the end so that the | ||
polynomials have the same length which is a power of 2 at least the length of | ||
their product. | ||
|
||
The unit tests demonstrate how the class can be used. | ||
""" | ||
|
||
import mpmath # for roots of unity | ||
import numpy as np | ||
|
||
|
||
class FFT: | ||
def __init__(self, polyA=[0], polyB=[0]): | ||
# Input as list | ||
self.polyA = list(polyA)[:] | ||
self.polyB = list(polyB)[:] | ||
|
||
# Remove leading zero coefficients | ||
while self.polyA[-1] == 0: | ||
self.polyA.pop() | ||
self.len_A = len(self.polyA) | ||
|
||
while self.polyB[-1] == 0: | ||
self.polyB.pop() | ||
self.len_B = len(self.polyB) | ||
|
||
# Add 0 to make lengths equal a power of 2 | ||
self.C_max_length = int( | ||
2 | ||
** np.ceil( | ||
np.log2( | ||
len(self.polyA) + len(self.polyB) - 1 | ||
) | ||
) | ||
) | ||
|
||
while len(self.polyA) < self.C_max_length: | ||
self.polyA.append(0) | ||
while len(self.polyB) < self.C_max_length: | ||
self.polyB.append(0) | ||
# A complex root used for the fourier transform | ||
self.root = complex( | ||
mpmath.root(x=1, n=self.C_max_length, k=1) | ||
) | ||
|
||
# The product | ||
self.product = self.__multiply() | ||
|
||
# Discrete fourier transform of A and B | ||
def __DFT(self, which): | ||
if which == "A": | ||
dft = [[x] for x in self.polyA] | ||
else: | ||
dft = [[x] for x in self.polyB] | ||
# Corner case | ||
if len(dft) <= 1: | ||
return dft[0] | ||
# | ||
next_ncol = self.C_max_length // 2 | ||
while next_ncol > 0: | ||
new_dft = [[] for i in range(next_ncol)] | ||
root = self.root ** next_ncol | ||
|
||
# First half of next step | ||
current_root = 1 | ||
for j in range( | ||
self.C_max_length // (next_ncol * 2) | ||
): | ||
for i in range(next_ncol): | ||
new_dft[i].append( | ||
dft[i][j] | ||
+ current_root | ||
* dft[i + next_ncol][j] | ||
) | ||
current_root *= root | ||
# Second half of next step | ||
current_root = 1 | ||
for j in range( | ||
self.C_max_length // (next_ncol * 2) | ||
): | ||
for i in range(next_ncol): | ||
new_dft[i].append( | ||
dft[i][j] | ||
- current_root | ||
* dft[i + next_ncol][j] | ||
) | ||
current_root *= root | ||
# Update | ||
dft = new_dft | ||
next_ncol = next_ncol // 2 | ||
return dft[0] | ||
|
||
# multiply the DFTs of A and B and find A*B | ||
def __multiply(self): | ||
dftA = self.__DFT("A") | ||
dftB = self.__DFT("B") | ||
inverseC = [ | ||
[ | ||
dftA[i] * dftB[i] | ||
for i in range(self.C_max_length) | ||
] | ||
] | ||
del dftA | ||
del dftB | ||
|
||
# Corner Case | ||
if len(inverseC[0]) <= 1: | ||
return inverseC[0] | ||
# Inverse DFT | ||
next_ncol = 2 | ||
while next_ncol <= self.C_max_length: | ||
new_inverseC = [[] for i in range(next_ncol)] | ||
root = self.root ** (next_ncol // 2) | ||
current_root = 1 | ||
# First half of next step | ||
for j in range(self.C_max_length // next_ncol): | ||
for i in range(next_ncol // 2): | ||
# Even positions | ||
new_inverseC[i].append( | ||
( | ||
inverseC[i][j] | ||
+ inverseC[i][ | ||
j | ||
+ self.C_max_length | ||
// next_ncol | ||
] | ||
) | ||
/ 2 | ||
) | ||
# Odd positions | ||
new_inverseC[i + next_ncol // 2].append( | ||
( | ||
inverseC[i][j] | ||
- inverseC[i][ | ||
j | ||
+ self.C_max_length | ||
// next_ncol | ||
] | ||
) | ||
/ (2 * current_root) | ||
) | ||
current_root *= root | ||
# Update | ||
inverseC = new_inverseC | ||
next_ncol *= 2 | ||
# Unpack | ||
inverseC = [ | ||
round(x[0].real, 8) + round(x[0].imag, 8) * 1j | ||
for x in inverseC | ||
] | ||
|
||
# Remove leading 0's | ||
while inverseC[-1] == 0: | ||
inverseC.pop() | ||
return inverseC | ||
|
||
# Overwrite __str__ for print(); Shows A, B and A*B | ||
def __str__(self): | ||
A = "A = " | ||
B = "B = " | ||
C = "A*B = " | ||
for i in range(self.len_A): | ||
A += str(self.polyA[i]) + "*x^" + str(i) + " + " | ||
for i in range(self.len_B): | ||
B += str(self.polyB[i]) + "*x^" + str(i) + " + " | ||
for i in range(self.len_B + self.len_A - 1): | ||
C += ( | ||
str(self.product[i]) | ||
+ "*x^" | ||
+ str(i) | ||
+ " + " | ||
) | ||
return A + "\n \n" + B + "\n \n" + C | ||
KirilBangachev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
# Unit tests | ||
if __name__ == "__main__": | ||
|
||
A = [0, 1, 0, 2] # x+2x^3 | ||
B = (2, 3, 4, 0) # 2+3x+4x^2 | ||
x = FFT(A, B) | ||
print(x.product) # 2x + 3x^2 + 8x^3 + 4x^4 + 6x^5, | ||
# as [(-0+0j), (2+0j), (3+0j), (8+0j), (6+0j), (8+0j)] | ||
print(x) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A += f"{self.polyA[i]}*x^{i} + "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the
__str__
method using f prefix for clarity and list comprehension+String.join() for performance.