Skip to content

fix: fix bug in timSort #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
23 changes: 22 additions & 1 deletion sorting/tim_sort.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// C++ program to perform TimSort.
#include <algorithm>
#include <cassert>
#include <iostream>
#include <numeric>

const int RUN = 32;

Expand Down Expand Up @@ -74,7 +76,7 @@ void timSort(int arr[], int n) {
for (int left = 0; left < n; left += 2 * size) {
// find ending point of left sub array
// mid+1 is starting point of right sub array
int mid = left + size - 1;
int mid = std::min((left + size - 1), (n - 1));
int right = std::min((left + 2 * size - 1), (n - 1));

// merge sub array arr[left.....mid] & arr[mid+1....right]
Expand All @@ -89,8 +91,27 @@ void printArray(int arr[], int n) {
std::cout << std::endl;
}

/**
* @brief self-test implementation
* @returns void
*/
void tests() {
// Case: array of length 65
constexpr int N = 65;
int arr[N];

std::iota(arr, arr + N, 0);
std::reverse(arr, arr + N);
assert(!std::is_sorted(arr, arr + N));

timSort(arr, N);
assert(std::is_sorted(arr, arr + N));
}

// Driver program to test above function
int main() {
tests(); // run self test implementations

int arr[] = {5, 21, 7, 23, 19};
int n = sizeof(arr) / sizeof(arr[0]);
printf("Given Array is\n");
Expand Down
Loading