fix(traceback): highlight win32 paths #3734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3734 +/- ##
==========================================
- Coverage 98.24% 97.98% -0.27%
==========================================
Files 74 74
Lines 8105 8142 +37
==========================================
+ Hits 7963 7978 +15
- Misses 142 164 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`PathHighlighter` uses a regex to parse paths for highlighting. It used `/` as the final path component delimiter. This diff changes that to "either `/` or `\`". I toyed with using `os.path.sep`, but there's no reason to *not* highlight paths from other OSes than the one we're running on at the moment.
abesto
force-pushed
the
fix/path-highlighter-windows
branch
from
0d3d5cf to
54d224f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
PathHighlighteruses a regex to parse paths for highlighting. It used/as the final path component delimiter. This PR changes that to "either/or\".I toyed with using
os.path.sep, but there's no reason to not highlight paths from other OSes than the one we're running on at the moment.