Repository navigation
fix(student-card): protect cached data and enforce validity dates - #388
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No linked issue. Cached cards could keep displaying an unconditional VALID badge after their validity dates passed. The cache also persisted token-bearing URLs and plaintext card details, and requests completing after logout could repopulate it.
Why this is useful for all students
Protects stored student-card photos and personal details, keeps expired cards visibly expired while offline, and prevents signed-out sessions from restoring old data.
Changes
Screenshot
The synthetic expired-card preview was visually checked in the iOS simulator. Reproduce with:
Validation
flutter analyze --no-pub: no issues.git diff --check: passed.Scope and migration
The upgrade discards existing cache entries; offline data becomes available again after a successful fetch. The cache directory may also be purged by the operating system.
These frontend changes protect local data and validity handling; they do not establish independent authenticity for a displayed card or detect early revocation while offline. Backend verification and production token transport changes are outside this PR.