Skip to content

Student Clubs full redesign proposal: list rows, detail sheet, search and categories - #383

Open
kurk-s wants to merge 1 commit into
TUM-Dev:mainfrom
kurk-s:feat/student-clubs-redesign
Open

kurk-s wants to merge 1 commit into
TUM-Dev:mainfrom
kurk-s:feat/student-clubs-redesign

Conversation

@kurk-s

@kurk-s kurk-s commented Nov 10, 2026

Copy link
Copy Markdown

Issue

There is no issue for this yet. I am opening this as a draft to get feedback on the design before it is considered for merging.

Why change?

My main goal with this redesign is that the Student Clubs page tells the user, before they tap, what a club does and where tapping will lead. Right now the page shows a name and a picture, and leaves the rest to guessing.

Problems

Layout
On the current Student Clubs page, it is hard to tell which clubs can be tapped. The page does not communicate which actions are possible. The grid is built around pictures, but many clubs have no logo, so most of the screen is taken up by identical placeholder icons instead of useful information.

Cards
The API sends a description for many clubs, but the app never shows it, so users cannot tell what a club does without leaving the app.
Every card looks tappable, but tapping a club without a website does nothing and gives no feedback. The real issue is that we never tell the user which clubs have a website, and therefore which cards actually lead somewhere.

Filtering
In my opinion, a horizontal bar of tabs works well for 3–5 options, but not for 12. Most categories are hidden off-screen, and you have to scroll the bar just to see what exists.
Users opening the page often don't know which category a club belongs to, so there is no way to simply browse everything. An "All categories" view solves that.
Since some clubs have no website, a "Has website" filter lets users quickly find the clubs they can easily look up before joining.

Screenshots

Before

Campus Page Student Clubs Page
Nothing signifies that a card can be clicked - Attention is drawn to placeholders
- No useful information is displayed
- No signifiers (user doesn't know what can and cannot be interacted with)

After

Campus Page Student Clubs Page
Links signify that a card can be clicked - Attention is drawn to information
- Name, description, image and stripped link are shown
- The link suggests clicking

Functionality:

Search & Filters Category Sheet Club Detail Sheet
A search clubs feature was added alongside the new categories selector and the "has website" filter. The search and filters bar is pinned to the top. Categories are structured vertically, which fits more information and arguably feels more natural and easier to navigate. Full description and an “Open website” button (when available). Opens from both the Student Clubs page and the Campus page.

Feedback I would like

  1. What do you think about replacing the category tabs with a category sheet?
  2. Are the changes to the shared CampusCollectionView fine, or would you prefer a separate view for clubs?
  3. Is the slightly taller club card on the Campus page OK?
  4. Overall opinion on the changes.

What changes

The motivation, screenshots, and everything else above are mine. The implementation and the following detailed description of the changes were written with Claude (Claude Code); I reviewed and tested them.

Student Clubs page

  • Clubs are shown as list rows instead of picture cards. Each row has the club logo (or its initials on a coloured background when there is no logo), a two-line preview of the description, and the website domain.
  • Only clubs that have a description or a website are tappable, and those show a chevron.
  • Tapping a club opens a detail sheet with the full description and an "Open website" button, instead of leaving the app straight away.
  • The category tabs are replaced by a button that opens a sheet listing all categories with their club counts. "All categories" shows every club, grouped under category headings.
  • New search field (searches name and description) and a "Has website" filter. Both stay pinned at the top while scrolling.
  • When search or filters match nothing, the page says so and offers "Clear filters".

Campus page

  • The club cards in the carousel now open the same detail sheet and show the website domain when there is one. Clubs without a description or website are no longer tappable. The cards are about 20 px taller.

Shared code

  • CampusCollectionView gained optional titled sections, a pinned header, and rows that are as tall as their content. News and Movies use it exactly as before.

Translations

  • 9 new strings in English and German.

Tests

  • 10 new widget tests for the club row and detail sheet, the Campus card and the clubs page (grouping, category sheet, search and filter, pinned header).
  • Two existing tests in test/campus/campus_collection_test.dart are adjusted for the clubs case only: the list is no longer a grid, and a category is now picked through a sheet instead of a tab.
  • flutter analyze reports no issues and all 392 tests pass.

…ories

- Show clubs as list rows with logo or initials, description preview and
  website domain; only clubs with details are tappable
- Open a detail sheet with the full description and an "Open website"
  button instead of launching the link directly
- Replace the category tabs with a category sheet and group all clubs
  under category headings
- Add search and a "Has website" filter, pinned above the list
- Let CampusCollectionView render titled sections, a pinned header,
  content-height rows and a custom empty state
- Make the Campus page club cards open the same sheet and show the link

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 23:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@jakobkoerber jakobkoerber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this redesign and for explaining the motivation so clearly! I like the overall design: the description previews, category picker, search and filters make the clubs much easier to browse, and the shared detail sheet is a nice improvement over opening a website immediately.

I went through the implementation as well and left a few suggestions, mainly around keeping the shared collection layout simple and making the shared club widgets easier to reuse. The layout structure is the main point I'd like us to discuss; the smaller suggestions are opportunities to simplify things. Flutter analysis is clean and all 392 tests passed in my local review.

this.emptyAction,
required this.minimumCardWidth,
required this.cardAspectRatio,
this.cardAspectRatio,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the different layout modes a little more explicit here? This component now handles flat items or sections, fixed-height grids or variable-height rows, and an optional pinned header, with the layout selected by whether the height parameters are null. Sharing the refresh/loading/error/empty states makes sense, but I wonder whether separate grid and sectioned-list renderers, or a shared wrapper that accepts content slivers, would keep this easier to maintain as News, Movies and Clubs evolve. Happy to discuss which approach fits best.

separatorBuilder: (context, _) =>
const SizedBox(height: 12),
itemBuilder: (context, row) =>
IntrinsicHeight(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a plain SliverList.separated when there is only one column? IntrinsicHeight makes sense if we want adjacent cards to have equal heights on wider screens, but in the single-column case the row can size itself naturally without the extra intrinsic measurement. I haven't observed a performance issue; this would mainly simplify the common phone layout and avoid unnecessary measurement.

),
],
),
],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that both the list and the Campus cards open the same detail sheet! Could we move the sheet and its opening function into student_club_sheet.dart, and the shared avatar into student_club_avatar.dart? Currently the carousel card imports the list-tile file to access the sheet. Giving these shared pieces their own files would make those dependencies clearer.

child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
TextField(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would Flutter's SearchBar work here instead of styling a TextField as a search bar? It seems like a good fit for filtering the existing list and would let us use the standard search styling/theming. I think keeping the controller and filtering state local to this screen is appropriate; we wouldn't need a SearchAnchor or the app's global-search view model. This is a consistency suggestion rather than a functional concern.


bool _matches(StudentClub club) {
if (_hasWebsite && !club.hasLink) return false;
final query = _search.text.trim().toLowerCase();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small simplification: could we normalize the query once per filtering pass rather than once for every club? Also, the Expando caches the parsed text for searching, while the row and sheet still parse descriptions repeatedly through the extension getters. For this collection size, computing the description once per widget build may be sufficient; if we keep a broader cache, it would be nice to have one clear place where display/search text is prepared. No need for a larger state-management change here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants