Repository navigation
Conversation
…ories - Show clubs as list rows with logo or initials, description preview and website domain; only clubs with details are tappable - Open a detail sheet with the full description and an "Open website" button instead of launching the link directly - Replace the category tabs with a category sheet and group all clubs under category headings - Add search and a "Has website" filter, pinned above the list - Let CampusCollectionView render titled sections, a pinned header, content-height rows and a custom empty state - Make the Campus page club cards open the same sheet and show the link Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
jakobkoerber
left a comment
There was a problem hiding this comment.
Thanks for contributing this redesign and for explaining the motivation so clearly! I like the overall design: the description previews, category picker, search and filters make the clubs much easier to browse, and the shared detail sheet is a nice improvement over opening a website immediately.
I went through the implementation as well and left a few suggestions, mainly around keeping the shared collection layout simple and making the shared club widgets easier to reuse. The layout structure is the main point I'd like us to discuss; the smaller suggestions are opportunities to simplify things. Flutter analysis is clean and all 392 tests passed in my local review.
| this.emptyAction, | ||
| required this.minimumCardWidth, | ||
| required this.cardAspectRatio, | ||
| this.cardAspectRatio, |
There was a problem hiding this comment.
Could we make the different layout modes a little more explicit here? This component now handles flat items or sections, fixed-height grids or variable-height rows, and an optional pinned header, with the layout selected by whether the height parameters are null. Sharing the refresh/loading/error/empty states makes sense, but I wonder whether separate grid and sectioned-list renderers, or a shared wrapper that accepts content slivers, would keep this easier to maintain as News, Movies and Clubs evolve. Happy to discuss which approach fits best.
| separatorBuilder: (context, _) => | ||
| const SizedBox(height: 12), | ||
| itemBuilder: (context, row) => | ||
| IntrinsicHeight( |
There was a problem hiding this comment.
Could we use a plain SliverList.separated when there is only one column? IntrinsicHeight makes sense if we want adjacent cards to have equal heights on wider screens, but in the single-column case the row can size itself naturally without the extra intrinsic measurement. I haven't observed a performance issue; this would mainly simplify the common phone layout and avoid unnecessary measurement.
| ), | ||
| ], | ||
| ), | ||
| ], |
There was a problem hiding this comment.
Nice that both the list and the Campus cards open the same detail sheet! Could we move the sheet and its opening function into student_club_sheet.dart, and the shared avatar into student_club_avatar.dart? Currently the carousel card imports the list-tile file to access the sheet. Giving these shared pieces their own files would make those dependencies clearer.
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.stretch, | ||
| children: [ | ||
| TextField( |
There was a problem hiding this comment.
Would Flutter's SearchBar work here instead of styling a TextField as a search bar? It seems like a good fit for filtering the existing list and would let us use the standard search styling/theming. I think keeping the controller and filtering state local to this screen is appropriate; we wouldn't need a SearchAnchor or the app's global-search view model. This is a consistency suggestion rather than a functional concern.
|
|
||
| bool _matches(StudentClub club) { | ||
| if (_hasWebsite && !club.hasLink) return false; | ||
| final query = _search.text.trim().toLowerCase(); |
There was a problem hiding this comment.
Small simplification: could we normalize the query once per filtering pass rather than once for every club? Also, the Expando caches the parsed text for searching, while the row and sheet still parse descriptions repeatedly through the extension getters. For this collection size, computing the description once per widget build may be sufficient; if we keep a broader cache, it would be nice to have one clear place where display/search text is prepared. No need for a larger state-management change here.
Issue
There is no issue for this yet. I am opening this as a draft to get feedback on the design before it is considered for merging.
Why change?
My main goal with this redesign is that the Student Clubs page tells the user, before they tap, what a club does and where tapping will lead. Right now the page shows a name and a picture, and leaves the rest to guessing.
Problems
Layout
On the current Student Clubs page, it is hard to tell which clubs can be tapped. The page does not communicate which actions are possible. The grid is built around pictures, but many clubs have no logo, so most of the screen is taken up by identical placeholder icons instead of useful information.
Cards
The API sends a description for many clubs, but the app never shows it, so users cannot tell what a club does without leaving the app.
Every card looks tappable, but tapping a club without a website does nothing and gives no feedback. The real issue is that we never tell the user which clubs have a website, and therefore which cards actually lead somewhere.
Filtering
In my opinion, a horizontal bar of tabs works well for 3–5 options, but not for 12. Most categories are hidden off-screen, and you have to scroll the bar just to see what exists.
Users opening the page often don't know which category a club belongs to, so there is no way to simply browse everything. An "All categories" view solves that.
Since some clubs have no website, a "Has website" filter lets users quickly find the clubs they can easily look up before joining.
Screenshots
Before
- No useful information is displayed
- No signifiers (user doesn't know what can and cannot be interacted with)
After
- Name, description, image and stripped link are shown
- The link suggests clicking
Functionality:
Feedback I would like
CampusCollectionViewfine, or would you prefer a separate view for clubs?What changes
Student Clubs page
Campus page
Shared code
CampusCollectionViewgained optional titled sections, a pinned header, and rows that are as tall as their content. News and Movies use it exactly as before.Translations
Tests
test/campus/campus_collection_test.dartare adjusted for the clubs case only: the list is no longer a grid, and a category is now picked through a sheet instead of a tab.flutter analyzereports no issues and all 392 tests pass.