Skip to content

Conversation

@WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Nov 21, 2024

Closes #1379

Why this PR ?

It's hard to debug the frontend because of these warnings

image

The react-native-slider fix:

https://github.com/callstack/react-native-slider/releases/tag/v4.5.3

@WaDadidou WaDadidou added the Social Feed Everything related to the Social Feed label Nov 21, 2024
@WaDadidou WaDadidou self-assigned this Nov 21, 2024
@netlify
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit ae5d305
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/673f7840e3d0260008956eb2
😎 Deploy Preview https://deploy-preview-1406--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit bbb8b48
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6744d6ab3a0bed00082150b1
😎 Deploy Preview https://deploy-preview-1406--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@n0izn0iz
Copy link
Collaborator

need to upgrade expo, this is not a light task, I think we should not tackle that right now

@WaDadidou
Copy link
Collaborator Author

need to upgrade expo, this is not a light task, I think we should not tackle that right now

Why expo ?

@n0izn0iz
Copy link
Collaborator

https://github.com/TERITORI/teritori-dapp/actions/runs/11959178214/job/33340393703?pr=1406#step:5:35

hthieu1110
hthieu1110 previously approved these changes Nov 23, 2024
Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hthieu1110 hthieu1110 dismissed their stale review November 23, 2024 15:02

didnt check Norman message

@netlify
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit bbb8b48
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/6744d6ab0fa41400088478aa
😎 Deploy Preview https://deploy-preview-1406--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou changed the title fix(feed:) Update slider package to prevent flooding warnings fix(feed): Update slider package to prevent flooding warnings Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Social Feed Everything related to the Social Feed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(feed): Slider floods browser console with StyleSheet warnings

4 participants