Skip to content

cleanup some url defs#884

Open
PeterHindes wants to merge 13 commits into
mainfrom
fix-setup
Open

cleanup some url defs#884
PeterHindes wants to merge 13 commits into
mainfrom
fix-setup

Conversation

@PeterHindes

@PeterHindes PeterHindes commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

This pull request makes the tests only run when files in the respective folder are changed. It also removes an unused file, and makes the names for the backend url stuff more consistent across the project.

@PeterHindes PeterHindes self-assigned this Jun 10, 2025
@PeterHindes
PeterHindes requested review from bigautam and cjmyers June 10, 2025 23:09
@cjmyers

cjmyers commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

BackendSS has a purpose. When you come to the hackathon tomorrow, I can explain why this is there.

@PeterHindes

Copy link
Copy Markdown
Contributor Author

ok, I have returned it in the contexts where it is appropriate, Im just double checking it now

@cjmyers

cjmyers commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Don't change the name of the variables. These are environment variables already in use with deployments.

@zane-perry zane-perry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Checks will also have to be updated for this to fully work. Currently the checks get stuck waiting for the Test Suite to pass when only one of the tests (frontend/backend) has run

@PeterHindes

Copy link
Copy Markdown
Contributor Author

good note, is there any way to make that a file edit, or do we have to use the settings of the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all useeffects should use backend not backendss Tests run for backend when only frontend files changed

3 participants