Skip to content

update to README.md #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update to README.md #99

wants to merge 1 commit into from

Conversation

mdbench
Copy link

@mdbench mdbench commented Feb 4, 2025

This update will make it easier for users of your package to understand how to implement it manually. I had to thoroughly examine your source code to arrive at this basic syntax, including understanding your bindings, as the syntax was missing from the documentation.

foregroundColor: .white,
hapticFeedback: .notification(.success),
onDismiss: {
UserDefaults.standard.set(false, forKey: "hasShowWhatsNew")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There looks to be a typo in this key

Suggested change
UserDefaults.standard.set(false, forKey: "hasShowWhatsNew")
UserDefaults.standard.set(false, forKey: "hasShownWhatsNew")

// ...
]
)

@State private var hasShownWhatsNew = UserDefaults.standard.bool(forKey: "hasShowWhatsNew")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Suggested change
@State private var hasShownWhatsNew = UserDefaults.standard.bool(forKey: "hasShowWhatsNew")
@State private var hasShownWhatsNew = UserDefaults.standard.bool(forKey: "hasShownWhatsNew")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants