Conversation
8770527 to
67af508
Compare
|
Do you have the lock file diff still? It gets printed after lock file generation. The diff view makes it much easier to see what changed. Reviewing the actual lock file changes is a lot. Also, I like to use that diff to update the version pins in the legacy requirements files. |
|
I don't have it, but it's nothing to re-run the generate process against master again. Would you like it as an attachment here? I can also backport the locking to the requirement files if you want that. |
Yes please. I try to put it in the diff in the commit message and in the PR description (in a Dealing with this is cumbersome. Maybe (in a different PR) we could add a GHA workflow that:
|
67af508 to
0cd8882
Compare
|
I pushed the generated lock files as well as the updates requirements.txt files. Here's the pants output: |
|
I think someone from the community pointed out bitnami doing something with their images, so the CI errors might be related to that. |
ef177bd to
57c1719
Compare
|
The tests are passing on the official rabbitmq 3.13 images, circleci looks like a conflict between package versions. It might be necessary to update requirements files in orquesta, ldap and rbac before the CircleCI tests pass. |
e48a5b0 to
3d77172
Compare
c2309ad to
e1a308e
Compare
|
Additional lock update |
| oslo.config==9.6.0 | ||
| oslo.utils==7.3.0 | ||
| paramiko==3.5.1 | ||
| passlib==1.7.4 |
There was a problem hiding this comment.
Nice find!
Just a note for future reference (if anyone happens to be spelunking through old changes): passlib is required by st2-auth-backend-flat-file, so we will still pull in the requirement through that dependency. Since nothing in this repo uses passlib, it is safe to remove it from the requirements files and let pip handle resolving transitive deps like passlib.
No description provided.