Skip to content

Support sharded pubsub commands #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support sharded pubsub commands #2887

wants to merge 3 commits into from
+217 −66

Conversation

mgravell
Copy link
Collaborator

Continuation of #2498

vandyvilla and others added 3 commits May 20, 2025 10:19
@vandyvilla @mgravell
Support sharded pubsub commands (#2498)
0172e03 
* Support sharded pubsub

* Support sharded pubsub

* fix api

* fix enum

* fix api

---------

Co-authored-by: Marc Gravell <[email protected]>
@mgravell @vandyvilla
Sharded proposal (#2886)
312dda9 
* Support sharded pubsub

* Support sharded pubsub

* fix api

* fix enum

* fix api

* proposed refactor to single-field implementation

* RedisDatabase needs to use SPUBLISH/PUBLISH correctly

* support ssub on CLIENT response

* add to features; fixup shipped etc

---------

Co-authored-by: xli <[email protected]>
@mgravell
fix initial build errors
98714d4
@mgravell mgravell mentioned this pull request May 20, 2025
Merged
@atakavci
Copy link
Contributor

hi @mgravell ,
i think there are issues around reconnects. And the other fails we see here are more likely to be flaky tests. let me know if am misinterpreting it.
Here i attempted to fix and test the reconnects with sharded pub/sub. Let me know if you would like me to change direction.
i am also planning to check with hashslot changes in another iteration, any initial suggestions/hints for that?

@mgravell
Copy link
Collaborator Author

important TODOs before final merge:

  • investigate break/reconnect logic
  • investigate cluster shard migration logic
  • investigate unsubscribe-all logic

@atakavci
Copy link
Contributor

atakavci commented Jun 4, 2025 •
edited
Loading

hey @mgravell , i think this branch fixes and tests reconnect logic as well as testing for hashslot migrations.

the only item remaining is unsubscribe-all logic; what should be the expected behaviour with unsubscribe-all??

  • investigate break/reconnect logic
  • investigate cluster shard migration logic
  • investigate unsubscribe-all logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgravell @atakavci @vandyvilla