Added boolean property IE9_optionalFile #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s without selecting a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added boolean property IE9_optionalFile in order to be able to do requests without any selected file. So the file can be optional and we can still send the data from other input fields passed as children to the FileUpload component.
The scenario that made me do this change for our project was because we have a comment textarea that we are passing to fileUpload as a child, but we wanted the file to be optional and only send the comment if the user doesn't want to attach a file (I only added the prop to work for IE9 in the IEUpload function because there is no issue with modern browsers when we don't attach any file)
You may have a better solution for this, but at least you can get my idea.
Thanks.