refactor: service response changes and dashboardID handling#11485
Open
swapnil-signoz wants to merge 2 commits into
Open
refactor: service response changes and dashboardID handling#11485swapnil-signoz wants to merge 2 commits into
swapnil-signoz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Refactoring Cloud Integration service details response and removed hacky version of assigning dashboard ID when metrics are enabled.
📄 Summary
Why does this change exist?
Code clean and removing hacking implementation for assigning dashboard ID, which was introduced when cloud integration dashboards were migrated to DB
What problem does it solve, and why is this the right approach?
Code clean up
Issues closed by this PR
https://github.com/SigNoz/engineering-pod/issues/5058
✅ Change Type
Select all that apply