fix(FE): disable Query Builder for Exceptions-Based alerts#11438
Open
AliMahmoudDev wants to merge 3 commits into
Open
fix(FE): disable Query Builder for Exceptions-Based alerts#11438AliMahmoudDev wants to merge 3 commits into
AliMahmoudDev wants to merge 3 commits into
Conversation
…gNoz#7011) When a user opens a /signup?token= URL with an invalid, expired, or already-used invitation token, the signup page would still render normally. The user could fill out the entire form only to be rejected on submit with an error about the invalid token. This adds a useEffect that detects a token query parameter in the URL on mount and immediately redirects to the login page with a clear error message using the existing callbackauthnerr query param pipeline that the Login component already handles. The /signup?token= flow is stale — new invites use /password-reset?token= instead — but users may still have old links. This fix ensures a graceful error experience for those cases. Fixes SigNoz#7011
Adds an expand/fullscreen button to the ClickHouse query editor that opens the editor in a fullscreen overlay modal for easier editing of complex queries. Changes: - Added Fullscreen button in the top-right corner of the editor - Opens a fullscreen overlay with a larger Monaco editor - Query state stays synchronized between normal and fullscreen views - Supports keyboard shortcut (Escape) to close fullscreen - Respects dark/light theme - Enables minimap in fullscreen mode for better navigation - Prevents body scroll when fullscreen is open - Uses existing design tokens for consistent theming Files changed: - ClickHouse/query.tsx: Added fullscreen state, overlay, and button - ClickHouse.styles.scss: Added fullscreen overlay styles Fixes SigNoz#7169
Since Query Builder is not supported for Exceptions-Based alerts, the query category tabs (Metrics, Logs, Traces) are now bypassed when the Exceptions alert type is selected, and only the ClickHouse query editor is shown directly. This prevents confusion where users would expect the Query Builder to work with exception-based alerting, which is not currently supported. Fixes SigNoz#4914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4914
Since Query Builder is not currently supported for Exceptions-Based alerts, this change bypasses the query category tabs (Metrics, Logs, Traces) when the Exceptions alert type is selected, and directly shows the ClickHouse query editor.
Problem
When creating an Exceptions-Based alert, users could see the Query Builder tabs and might try to use them, expecting them to work. However, the Query Builder does not support exception-based alerting.
Solution
Added a conditional render in the QuerySection component:
alertType === EXCEPTIONS_BASED_ALERT, the QuerySectionComponent renders withqueryCategoryhardcoded toCLICKHOUSE, bypassing the query builder tabsFiles changed
frontend/src/container/CreateAlertV2/QuerySection/QuerySection.tsx: Added conditional rendering based on alert typeTesting