Update README.md#645
Merged
abecevello merged 1 commit intoShopify:mainfrom May 28, 2025
Merged
Conversation
While using the Go client (`github.com/Shopify/toxiproxy/client`), I found that after creating a proxy and adding toxics via `proxy.AddToxic(...)`, the toxic does not take effect unless I explicitly call `proxy.Save()` afterward. This is not currently mentioned in the documentation or examples, and it caused some confusion when toxics weren’t being applied despite no errors during creation. **Suggestions:** - Mention this requirement in the README and/or inline GoDoc. - Possibly make `AddToxic` call `Save()` internally, or clarify the design choice if not.
Contributor
Author
|
I have signed the CLA! |
abecevello
approved these changes
May 28, 2025
Member
abecevello
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the Go client (
github.com/Shopify/toxiproxy/client), I found that after creating a proxy and adding toxics viaproxy.AddToxic(...), the toxic does not take effect unless I explicitly callproxy.Save()afterward.This is not currently mentioned in the documentation or examples, and it caused some confusion when toxics weren’t being applied despite no errors during creation.
Example:
Suggestions:
AddToxiccallSave()internally, or clarify the design choice if not.