Skip to content

Update waits Doc for zh-cn #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2025

Conversation

alaahong
Copy link
Member

@alaahong alaahong commented Jun 5, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Update waits Doc for zh-cn

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Improved and expanded the Chinese translation for the waits documentation

  • Enhanced clarity and accuracy of technical explanations

  • Updated terminology and formatting for consistency

  • Added more detailed examples and warnings in Chinese


Changes walkthrough 📝

Relevant files
Documentation
waits.zh-cn.md
Comprehensive rewrite and improvement of waits documentation (zh-cn)

website_and_docs/content/documentation/webdriver/waits.zh-cn.md

  • Rewrote and expanded the introduction and explanations in Chinese
  • Improved translation accuracy and technical clarity throughout the
    document
  • Updated section titles, warnings, and examples for better readability
  • Enhanced formatting and consistency with the English version
  • +100/-79

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Jun 5, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit e51c06b

    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Formatting Issue

    The code block at line 161 contains an English comment "The easiest way to customize Waits in Java is to use the FluentWait class:" that should be translated to Chinese for consistency with the rest of the document.

    The easiest way to customize Waits in Java is to use the `FluentWait` class: 
    {{< gh-codeblock path="examples/java/src/test/java/dev/selenium/waits/WaitsTest.java#L82-L92" >}}

    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix broken URL format
    Suggestion Impact:The commit implemented exactly what was suggested - removing the space after the colon in the URL to fix the broken link format

    code diff:

    -以这个页面为例:https: //www.selenium.dev/selenium/web/dynamic.html 
    +以这个页面为例:https://www.selenium.dev/selenium/web/dynamic.html 

    Remove the space after the colon in the URL to ensure the link works properly.
    The current format with a space after the colon will break the URL when clicked.

    website_and_docs/content/documentation/webdriver/waits.zh-cn.md [32]

    -以这个页面为例:https: //www.selenium.dev/selenium/web/dynamic.html
    +以这个页面为例:https://www.selenium.dev/selenium/web/dynamic.html

    [Suggestion processed]

    Suggestion importance[1-10]: 7

    __

    Why: This suggestion correctly identifies and fixes a malformed URL where there's an extra space after the colon in https: //. This would break the link functionality and should be corrected.

    Medium
    • Update

    @alaahong alaahong merged commit 26b7463 into SeleniumHQ:trunk Jun 5, 2025
    3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant