Skip to content

[ci] Upload autoscaling in K8s test results #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Dec 13, 2024

This PR contains the results of the autoscaling tests in Kubernetes

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Performance Concern
High session creation times (>50s) in some iterations may indicate performance bottlenecks in pod scaling

Resource Efficiency
Large number of gaps between total pods and running sessions indicates potential resource underutilization

Resource Allocation
High gap numbers (>15) suggest suboptimal pod allocation and potential resource waste

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Possible issue
Fix invalid negative pod scaling value that indicates a potential bug in the scaling logic

The negative value (-5) for "New pods scaled up" in iteration 14 indicates an
invalid scaling operation. Pod scaling should not go below zero. This needs to be
investigated and fixed in the test implementation.

.keda/results_test_k8s_autoscaling_deployment_count.md [16]

-| 14        | 2                    | 30.11 s               | 0                         | -5                 | 6                      | 7                  | 1                    | 1    | 0               |
+| 14        | 2                    | 30.11 s               | 0                         | 0                  | 6                      | 7                  | 1                    | 1    | 0               |
  • Apply this suggestion
Suggestion importance[1-10]: 9

Why: The negative value of -5 for pod scaling is logically invalid and indicates a serious bug in the autoscaling implementation that needs immediate attention, as pod counts should never be negative.

9

@VietND96 VietND96 force-pushed the bump-keda-patch branch 5 times, most recently from c6cd4b4 to 34ad7de Compare December 19, 2024 19:12
Copy link

qodo-merge-pro bot commented Dec 23, 2024

CI Failure Feedback 🧐

(Checks updated until commit 88d1a67)

Action: Rerun workflow when failure

Failed stage: Authenticate GitHub CLI for PR [❌]

Failure summary:

The action failed because the GitHub authentication token lacks the required 'read:org' permission
scope. The error occurred during the gh auth login command, which requires proper authorization
scopes to interact with GitHub's API.

Relevant error logs:
1:  ##[group]Operating System
2:  Ubuntu
...

28:  SecurityEvents: write
29:  Statuses: write
30:  ##[endgroup]
31:  Secret source: Actions
32:  Prepare workflow directory
33:  Prepare all required actions
34:  Getting action download info
35:  Download action repository 'actions/checkout@main' (SHA:cbb722410c2e876e24abbe8de2cc27693e501dcb)
36:  Complete job name: Rerun workflow when failure
...

48:  show-progress: true
49:  lfs: false
50:  submodules: false
51:  set-safe-directory: true
52:  env:
53:  GH_CLI_TOKEN: ***
54:  GH_CLI_TOKEN_PR: ***
55:  RUN_ID: 12479162459
56:  RERUN_FAILED_ONLY: true
...

119:  ##[group]Run sudo apt update
120:  �[36;1msudo apt update�[0m
121:  �[36;1msudo apt install gh�[0m
122:  shell: /usr/bin/bash -e {0}
123:  env:
124:  GH_CLI_TOKEN: ***
125:  GH_CLI_TOKEN_PR: ***
126:  RUN_ID: 12479162459
127:  RERUN_FAILED_ONLY: true
...

164:  0 upgraded, 0 newly installed, 0 to remove and 48 not upgraded.
165:  ##[group]Run echo "$GH_CLI_TOKEN_PR" | gh auth login --with-token
166:  �[36;1mecho "$GH_CLI_TOKEN_PR" | gh auth login --with-token�[0m
167:  shell: /usr/bin/bash -e {0}
168:  env:
169:  GH_CLI_TOKEN: ***
170:  GH_CLI_TOKEN_PR: ***
171:  RUN_ID: 12479162459
172:  RERUN_FAILED_ONLY: true
173:  RUN_ATTEMPT: 1
174:  ##[endgroup]
175:  error validating token: missing required scope 'read:org'
176:  ##[error]Process completed with exit code 1.

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

@VietND96 VietND96 force-pushed the bump-keda-patch branch 12 times, most recently from 3f07a05 to 049cea8 Compare December 24, 2024 05:45
An error occurred while trying to automatically change base from bump-keda-patch to trunk December 24, 2024 06:53
@VietND96 VietND96 deleted the branch bump-keda-patch January 2, 2025 02:38
@VietND96 VietND96 closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants