feat: Add tracing spans for database operations #2885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional tracing instrumentation for database operations, enabling distributed tracing and observability.
tracing-spansfeature flag for opt-in tracing supportexecute,query_one,query_all) and transaction flows (begin,commit,rollback)db.system,db.operation,db.statement,otel.status_code).instrument(span)pattern for proper async span context propagationMotivation
As noted in #2867, logs alone make it difficult to understand database call hierarchies and timing within request contexts. Spans provide:
Design Decision
The original issue proposed an
ObservabilityHookpattern. This PR takes a simpler approach by using thetracingcrate directly:tracingis the de facto standard for Rust instrumentationUsage
Span Attributes
db.systempostgresql,mysql,sqlitedb.operationSELECT,INSERT,UPDATE,DELETEdb.statementSELECT * FROM users WHERE id = $1otel.status_codeOK,ERRORexception.messageCloses #2867