Skip to content

Allow derived coord references to be lazy. #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jun 17, 2025

Noticed during testing for #6404, and implementing solution #6515

The old code used src.data when attaching a reference surface to a factory, but clearly src.core_data() makes a lot more sense, as a factory generally represents a "lazy" calculation anyway.

Although worth considering a separate issue, I want to test this alongside a completed #6515 + be merged into that when it's clear it doesn't break it.
Hence WIP : intend to merge into #6515 when ready

@pp-mo pp-mo mentioned this pull request Jun 17, 2025
6 tasks
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (90e36fe) to head (80235cf).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6517      +/-   ##
==========================================
+ Coverage   89.80%   89.87%   +0.06%     
==========================================
  Files          90       90              
  Lines       23752    23908     +156     
  Branches     4418     4459      +41     
==========================================
+ Hits        21331    21487     +156     
+ Misses       1672     1669       -3     
- Partials      749      752       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjlittle bjlittle linked an issue Jun 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Memory issues loading pp files with default LOAD_POLICY
1 participant