fix: update modelingtoolkit_remake tests for MTK v11 compatibility #1215
+45
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DiffEqNoiseProcess dependency for SDE/SDDE tests - Remove q parameter tests since MTK v11 bindings cannot involve only parameters (bindings must involve unknowns) - Change defaults to initial_conditions for DiscreteProblem - Update "remake with defaults containing expressions" test to use v11 approach (explicit parameter values instead of state-dependent defaults) - Update "remake with parameter dependent on observed" test to use v11 approach (parameter must be part of system equations) - Change parameter_dependencies to bindings syntax Fixes SciML#1192 Co-Authored-By: Claude Opus 4.5 <[email protected]>
ChrisRackauckas-Claude
force-pushed
the
fix-mtk-v11-tests
branch
from
c166826 to
f27a0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
qparameter andparameter_dependenciessince MTK v11 usesbindings(and bindings cannot depend on state variables)defaultstoinitial_conditionsfor DiscreteProblemparameter_dependenciestobindingssyntaxTest plan
modelingtoolkit_remake.jltests locally - 240 passed, 3 broken (expected)Fixes #1192
🤖 Generated with Claude Code