Fix dependency owner references in InterfaceI tests - #4987
Merged
ChrisRackauckas merged 1 commit intoAug 17, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
CI infrastructure note: the initial target downgrade job failed before checkout or Julia because GitHub codeload returned HTTP 503 and then 429 while downloading julia-actions/julia-downgrade-compat@v2. Multiple unrelated matrix jobs failed at the same time while downloading other action archives. The target job needs a maintainer rerun; this account receives HTTP 403 on the rerun endpoint.
The exact downgraded InterfaceI group passed locally: 1486 pass / 3 broken. |
ChrisRackauckas
marked this pull request as ready for review
August 17, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed
InterfaceI tests now access
jacobian_sparsity,BipartiteEdge,distribute_shift, andsimplify_shiftsthrough the dependency modules that own them. The unusedSystemStructureimport fromModelingToolkit.StructuralTransformationsis removed.This is test-only: it does not restore stale compatibility bindings or change package behavior/API.
Root cause
The import cleanup in commit
03c130782349ca8ed91e4f9a92da08d590c53fferemoved internal dependency aliases fromModelingToolkitandModelingToolkit.StructuralTransformations, but these three test files still reached five names through those modules. The source boundary is adjacent and independently reproducible: parent64ced006057dfef83d26f8941767c2a74653e1e6was green, while the cleanup commit and every current master/PR Julia leg below report the same nine errors.Restoring the aliases is not a valid fix: I ran
GROUP=QAwith that version and ExplicitImports rejected all five as stale explicit imports. Qualifying the existing tests throughModelingToolkitBaseandBipartiteGraphspreserves the import-cleanup invariant.The exact downgraded graph used locally included ModelingToolkitBase 1.66.0, ModelingToolkitTearing 1.19.2, BipartiteGraphs 0.1.4, StateSelection 1.11.0, Symbolics 7.32.1, SymbolicUtils 4.37.0, SymbolicIndexingInterface 0.3.46, SciMLBase 3.48.0, and OrdinaryDiffEqCore 4.12.0.
Verification
Failure before
At clean master SHA
3fe375e19031102e95c7775c4d8a6aac9895767b, the exact local Julia 1.10.12 downgrade run reproduced all nine existingUndefVarErrors for the five names. Four temporary diagnostic binding assertions made the aggregate:Those diagnostic assertions are not in this diff. The clean-master CI job without them reports
1330 pass / 9 error / 3 broken.Passing after
JULIA_DEPOT_PATH=/home/crackauc/sandbox/tmp_20260811_090509_69787/.mtk-downgrade-interface-depot \ GROUP=InterfaceI timeout 7200 julia +1.10.12 --startup-file=no --color=no \ --project=. -e 'using Pkg; Pkg.test()'JULIA_DEPOT_PATH=/home/crackauc/sandbox/tmp_20260811_090509_69787/.mtk-downgrade-interface-depot \ GROUP=QA timeout 7200 julia +1.12 --startup-file=no --color=no \ --project=. -e 'using Pkg; Pkg.test()'Also passed:
julia +1.12 --startup-file=no -m Runic --check \ test/reduction.jl test/structural_transformation/utils.jl \ test/structural_transformation/tearing.jl git diff --no-ext-diff --unified=0 | typos - git diff --checkDocs were not run because the patch changes only tests and does not touch documentation, docstrings, or public API.
GROUP=Everything, sublibrary groups, GPU paths, and allowed-to-fail Julia-pre/downstream paths were not run locally.The separate sublibrary downgrade failure is nine
OrdinaryDiffEqCore.DEOptionsconstructor errors, not this missing-name cluster. The downgraded BoundaryValueDiffEqMIRKCartesianIndex + Intprecompile workload and Moshi method-overwrite precompile errors also reproduced locally;Pkg.test()continued past them. None is changed here.Links