Skip to content

fix: enable support for complex ODEProblem again #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/systems/index_cache.jl
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ function IndexCache(sys::AbstractSystem)
observed_syms_to_timeseries,
dependent_pars_to_timeseries,
disc_buffer_templates,
BufferTemplate(Real, tunable_buffer_size),
BufferTemplate(Real, initials_buffer_size),
BufferTemplate(Number, tunable_buffer_size),
BufferTemplate(Number, initials_buffer_size),
const_buffer_sizes,
nonnumeric_buffer_sizes,
symbol_to_variable
Expand Down
6 changes: 3 additions & 3 deletions src/systems/problem_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,7 @@ end
$(TYPEDEF)

A callable struct to use as the `get_updated_u0` field of `InitializationMetadata`.
Returns the value to use for the `u0` of the problem.
Returns the value to use for the `u0` of the problem.

# Fields

Expand Down Expand Up @@ -1185,7 +1185,7 @@ function float_type_from_varmap(varmap, floatT = Bool)

if v isa AbstractArray
floatT = promote_type(floatT, eltype(v))
elseif v isa Real
elseif v isa Number
floatT = promote_type(floatT, typeof(v))
end
end
Expand Down Expand Up @@ -1451,7 +1451,7 @@ function check_inputmap_keys(sys, op)
end

const BAD_KEY_MESSAGE = """
Undefined keys found in the parameter or initial condition maps. Check if symbolic variable names have been reassigned.
Undefined keys found in the parameter or initial condition maps. Check if symbolic variable names have been reassigned.
The following keys are invalid:
"""

Expand Down
28 changes: 28 additions & 0 deletions test/complex.jl
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,31 @@ using Test
end
@named mixed = ComplexModel()
@test length(equations(mixed)) == 2

@testset "Complex ODEProblem" begin
using ModelingToolkit: t_nounits as t, D_nounits as D

vars = @variables x(t) y(t) z(t)
pars = @parameters a b

eqs = [
D(x) ~ y - x,
D(y) ~ -x * z + b * abs(z),
D(z) ~ x * y - a
]
@named modlorenz = System(eqs, t)
sys = mtkcompile(modlorenz)

ic = ModelingToolkit.get_index_cache(sys)
@test ic.tunable_buffer_size.type == Number

u0 = ComplexF64[-4.0, 5.0, 0.0] .+ randn(ComplexF64, 3)
p = ComplexF64[5.0, 0.1]
dict = merge(Dict(unknowns(sys) .=> u0), Dict(parameters(sys) .=> p))
prob = ODEProblem(sys, dict, (0.0, 1.0))

using OrdinaryDiffEq
sol = solve(prob, Tsit5(), saveat = 0.1)

@test sol.u[1] isa Vector{ComplexF64}
end
Loading