-
-
Notifications
You must be signed in to change notification settings - Fork 227
fix: enable support for complex ODEProblem again #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is their a chance this change can be backported to v9? As of v9.73 complex ODEProblem solving is broken. |
Yeah @AayushSabharwal could setup the backport. |
Awesome :) |
This implementation will cause all tunables and constant parameters to be stored as complex values if anything is complex. I'm not sure if that's what we want. |
I think that's right due to the promotion rules? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't particularly mind it either way, just making sure we're on the same page. The operating point [x => 0.5im, par => 5]
will cause par
to promote to 5.0 + 0.0im
.
Yes I think that's expected, because the derivative will also have non-trivial complex values, so at least the tunables needs to change to complex. |
Can you do the backport? |
Sure |
bump for the backport |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
resolves #3763